IOPBios: use memcpy read/write functions instead of 8 bit loops #12087
+16
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Instead of moving data in 8-bit loops, use safeiopmem(read/write) functions which use an underlying memcpy.
Rationale behind Changes
Minor performance increase in medium to large ioman I/O
When reading hostfs on master, our hottest point (besides the EE JIT) was the recClearIOP function called by each iopMemWrite8.
With this PR we now see faster execution times (~8.5%) with my hostfs bench-marking tool, and more CPU time on read().
Suggested Testing Steps
See if games and homebrew that uses HostFS still work.