Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IOPBios: use memcpy read/write functions instead of 8 bit loops #12087

Merged
merged 2 commits into from
Dec 18, 2024

Conversation

F0bes
Copy link
Member

@F0bes F0bes commented Dec 14, 2024

Description of Changes

Instead of moving data in 8-bit loops, use safeiopmem(read/write) functions which use an underlying memcpy.

Rationale behind Changes

Minor performance increase in medium to large ioman I/O

When reading hostfs on master, our hottest point (besides the EE JIT) was the recClearIOP function called by each iopMemWrite8.
With this PR we now see faster execution times (~8.5%) with my hostfs bench-marking tool, and more CPU time on read().

Suggested Testing Steps

See if games and homebrew that uses HostFS still work.

@F0bes F0bes merged commit 5a8921d into master Dec 18, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant