-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re:Re:Fix & Add Japanese Game Titles. #12089
Conversation
You may want to run ajv locally to fix the issues instead of waiting for the CI to run after each one
Edit: I went through and fixed the validation issues |
Also, you can just add more commits instead of opening a new PR for each one |
Oh! I will more learn about github! Thank you. |
I made a few more changes:
Let me know if those make sense to you and if so, I'll squish them all into the main commit so the change list is a bit smaller. |
I assume that name: and name-sort: in Japanese games are all full-width "!". I think it's okay to use half-width characters for name-en: in Japanese games as well. |
Correct. |
58e0e0d
to
cf6353f
Compare
I've squished all the commits into one. |
Yes, It seems very nice. The most important purpose this time is to display Japanese and sort based on Japanese as much as possible. It's was done by your help! In the future, I would like to modify the Demo/Trial version and make minor corrections. |
Sounds good. Make a new PR with that when you're ready. |
@nassau-tk: |
Shouldn't I have fixed it personally? |
Description of Changes
Fixed a large number of Japanese game titles.
And, Re-fix [ name-en: ].
*Trial & Demo will fix later.
Rationale behind Changes
This is a difficult task for non-Japanese people, so I did it myself.
*I'm JP.
Suggested Testing Steps
Put on the "resources" folder and check booting PCSX2.
If the .yaml file has problem then PCSX2 will not boot(Crash).
This is [Third attempt] lol