ChdFileReader: Migrate libchdr patch into PCSX2 #12097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added function didn't need to be in libchdr
github-actions
bot
added
CDVD
Dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Migrate added
chd_is_matching_parentfunction into PCSX2 codeRationale behind Changes
Such patches can be missed when updating dependencies, potentially leading to difficulty updating.
Added function works just as well when within PCSX2 code.
Suggested Testing Steps
Test CHD files with parent CHD files and see if they still open. (see #12076 for how to create them)