QT: set Texture Offsets & Skipdraw Range per game only

[Mrlinkwii]

Rationale behind Changes

Fixes #6181

Making Texture Offsets & Skipdraw Range less dangerous

Suggested Testing Steps

make sure QT compiles and make sure Texture Offsets & Skipdraw Range are per game only and they work

[mirh]

The user just asked for the thing to work in the game-specific properties.
Then, to be sure they are two options that have little "general" sense... but ironically I find this location way easier for testing (be it just muscle memory, or even "not having every toggle with an extra state to cycle through").

[refractionpcsx2]

Users are a danger to themselves, and setting it globally could break a lot of games, and cause extra headaches for us.

Making it per game makes a lot more sense, for the mild inconvenience of having to go to a different location when you're messing with it.

[mirh]

Nobody is questioning the sense of making it per game... the striking aspect is just the "only" part.

To be sure the average intelligence of the average joe can never be underestimated, but you could apply the same reasoning to just about any other global setting then.
I mean, of course they are far less "custom tailored" than numeric properties with 1000 possible values, but nonetheless the point here is forgetfulness, not how much you could break games once that may have kicked in.

And it's not just the inertia of "old habits", working only with the global settings is exactly how you can rest assured that you are never going to see surprises from whatever old config that you might have forgotten (ironically enough, trying to play once with skipdraw following this PR, just got me banging my head for half a hour before realizing it was not only PCSX2.ini that I had to keep track of but the gamesettings folder too).

[refractionpcsx2]

That sounds like a you problem ;)

[mirh]

"Fearing lots of headaches because dumb users could tinker with setting globally" is not a me problem.
The same token could be used for everything else too, from interlacing to CRC fixes or texture replacement.
It doesn't make sense that you have to switch panels back and forth if you want to adjust everything (and again, not because I have an heavy ass, but because somehow the one where zoom controls are available is not the one where texture offsets work).

[refractionpcsx2]

"Fearing lots of headaches because dumb users could tinker with setting globally" is not a me problem.

No, but going in to per game settings, screwing it up completely, rage quitting (apparently), then forgetting you completely screwed it up, is very much a user error, not our problem.

The same token could be used for everything else too, from interlacing to CRC fixes or texture replacement. It doesn't make sense that you have to switch panels back and forth if you want to adjust everything (and again, not because I have an heavy ass, but because somehow the one where zoom controls are available is not the one where texture offsets work).

You want it all on one panel? How on earth do you expect to fit all that in? or do you mean all in one place? cos you can set it all in one place, you don't have to keep coming out and going in to another section.

[mirh]

No, but going in to per game settings, screwing it up completely, rage quitting (apparently), then forgetting you completely screwed it up, is very much a user error, not our problem.

I'm not sure I understood the rage quitting part, anyhow you literally just described your grievance.
Yes, this is something for the users to handle on their own - still you don't (understandably) want the most clueless ones to come nagging you for such stupidities.

But "how much any given one setting could ever be specifically tailored to a game" (which fairly enough these two settings are the most of any other one) is not the same of "how much they are likely to cause problems" and thus be noticed (trivially, for instance it seems to me the resolution option carries a superset of all the nuisances that "texture offsets" could ever entail).
And on top of this, what you care for here isn't just a function of "erring happening", but you also need the user to be duped far enough that they end up reporting it.

Clearly this can happen as I myself suggested (even though I could eventually come to a close on my own) but even mistakes do have a logic behind.
Which arguably is something on the lines of "forgetting about previous choices" or at least "not knowing how settings precedence work".

And what I'm saying is, if you let each "settings view" have different sets of available options, more people will potentially have to hop through both of them. And so you are actually increasing the likelihood of users getting the idiot ball.

You want it all on one panel? How on earth do you expect to fit all that in? or do you mean all in one place?

Ehrm.. "one setting window" then?
Not sure how I could be clearer. My example was that crop and zoom are greyed out in games' own properties.

[mirh]

That sounds like a you problem ;)

:)

[refractionpcsx2]

That sounds like a you problem ;)

:)

What's your point? also why are you bumping something from a year and a half ago?

[mirh]

Because I had UX concerns (which I had spent quite the time to word and frame half decently), and you eventually shot them down as something just kinda airy on my side? And then it also happened to you (and yes, of course it's not a big deal, but the fact that it can be a thing at all is enough to make me wish for improvements).

Though I guess it was bad taste to bump a PR then, my fault for not having the will to write a proper issue.

[refractionpcsx2]

But what happened to me was user error, not a design error. What happened was exactly what should happen, your point was not proven here.

And having everything global is still a ridiculous idea, a lot of options are too dangerous to have globally.

Your issue will be denied if you make one on the previously mentioned issue.