Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qt: Bug fixes #9931

Merged
merged 12 commits into from
Sep 10, 2023
Merged

Qt: Bug fixes #9931

merged 12 commits into from
Sep 10, 2023

Conversation

stenzek
Copy link
Contributor

@stenzek stenzek commented Sep 9, 2023

Description of Changes

See commit lists, UI stuff is so boring these days that I can't be arsed re-writing it.

Rationale behind Changes

Closes #6159.
Closes #8044.
Closes #9869.
Closes #9914.
Closes #7215.
Closes #4634.
Closes #9139.
Closes #7681.

Suggested Testing Steps

Test linked issues.

@github-actions github-actions bot added the GUI/Qt label Sep 9, 2023
@bigol83
Copy link

bigol83 commented Sep 9, 2023

Everything works as it should, except for the last issue, #7681 it's not completely fixed.

When dragging ISO to Pcsx2 window, waiting for it to run, then dragging an elf file it correctly switches after confirmation.
Instead when dragging an elf file first, waiting for it to run, then draggin an ISO file, it doesn't switches after resetting.

I tested this with padtest.elf and ICO ISO file.

@stenzek
Copy link
Contributor Author

stenzek commented Sep 9, 2023

That's kinda working as expected. The ELF is set as the override, and will take precedence over the ISO.

Clearing the ELF override on ISO mount doesn't necessarily make sense either.

Edit: Ended up going for the middle ground option - swap disc won't clear the ELF override, but reset will.

@stenzek stenzek merged commit 3f9e473 into PCSX2:master Sep 10, 2023
12 checks passed
@stenzek stenzek deleted the qt branch September 10, 2023 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment