GS/HW: Don't allow PCRTC frames pull RGB from depth #9964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refractionpcsx2
force-pushed
the
gs_noframedepth
branch
from
d7ac4a3 to
f99260c
Compare
Mrlinkwii
approved these changes
Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Don't allow PCRTC frames to pull from depth
Rationale behind Changes
Depth should never be something used as an output frame, and this was causing problems with Neo Contra where instead of pulling from GS memory, it was copying from an old depth buffer.
Suggested Testing Steps
Try Neo Contra, and I guess some random stuff.
Fixes Neo Contra FMV's
Master:
PR: