de-deprecate with=>'fits resample'

PDLPorters · Jul 2, 2024 · 3ca14eb · 3ca14eb
1 parent 77c8464
commit 3ca14eb
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 1 deletion.
diff --git a/CHANGES b/CHANGES
@@ -1,3 +1,5 @@
+- de-deprecate with=>'fits resample'
+
 2.026 2024-04-20
 - fix {colorbox=>1} (#100)
 

diff --git a/README.pod b/README.pod
@@ -6,6 +6,8 @@ page at L<http://metacpan.org/pod/PDL::Graphics::Gnuplot>.
 
 =cut
 
+=encoding UTF-8
+
 =head1 NAME
 
 PDL::Graphics::Gnuplot - Gnuplot-based plotting for PDL
@@ -527,6 +529,8 @@ cut down on the burden of transferring large blocks of image data or
 to rectify images with nonlinear WCS transformations in their headers.
 (gnuplot itself has a bug that prevents direct rendering of images in
 nonlinear coordinates).
+Note this format is still allowed despite "complex with" being otherwise
+deprecated.
 
  gplot( with=>'fits res 200', $fitsdata );
  gplot( with=>'fits res 100,400',$fitsdata );

diff --git a/lib/PDL/Graphics/Gnuplot.pm b/lib/PDL/Graphics/Gnuplot.pm
@@ -592,6 +592,8 @@ cut down on the burden of transferring large blocks of image data or
 to rectify images with nonlinear WCS transformations in their headers.
 (gnuplot itself has a bug that prevents direct rendering of images in
 nonlinear coordinates).
+Note this format is still allowed despite "complex with" being otherwise
+deprecated.
 
  gplot( with=>'fits res 200', $fitsdata );
  gplot( with=>'fits res 100,400',$fitsdata );
@@ -3414,7 +3416,7 @@ sub parseArgs
     } else {
       @with = @{$chunk{options}{with}};
     }
-    if(@with > 1) {
+    if ($with[0] ne 'fits' and @with > 1) {
       carp q{
 WARNING: deprecated usage of complex 'with' detected.  Use a simple 'with'
 specifier and curve options instead.  This will fail in future releases of