error if undefined values to PDL constructors

PDLPorters · Oct 24, 2024 · 14177b7 · 14177b7
1 parent db72e96
commit 14177b7
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/Basic/Core/Core.xs b/Basic/Core/Core.xs
@@ -204,6 +204,9 @@ new_from_specification(invoc, ...)
         XSRETURN(1);
       }
     }
+    IV i; for (i = 0; i < items; i++)
+      if (!SvOK(ST(i)))
+        barf("Arg %"IVdf" is undefined", i);
     IV argstart = 1, type = PDL_D;
     if (items > 1 && sv_derived_from(ST(1), "PDL::Type")) {
       argstart++;

diff --git a/Changes b/Changes
@@ -15,6 +15,7 @@
 - get_dataref now works even with DONTTOUCHDATA which is really about allocation
 - if $pdl->{PDL} is code ref, $pdl now passed as arg
 - add PDL::Hash to simplify hash-based PDL subclasses
+- now an error to pass any undefined values to PDL constructors
 
 2.093 2024-09-29
 - PDL.set_datatype now doesn't physicalise input, PDL.convert_type does