Draft: Port: Add UnknownActivityAborted session #98
+64
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Session context struct avoids changes on previos sequence
Port Session context struct avoids changes on previos sequence to MORYX 6
…tion Replace deprecated github action
The new type is a session-wrapper for activities that should be aborted, but for which the session is unknown for a cell. It can be created and uses a new session context.
1nf0rmagician
changed the title
seveneleven
reviewed
Dec 2, 2024
| /// <param name="unknown"></param> | ||
| public static UnknownActivityAborted WrapUnknownActivity(IActivity unknown) | ||
| { | ||
| unknown.Fail(); |
There was a problem hiding this comment.
Why is the unknown activity failed here and also in the UnknownActivityAborted constructor?
| @@ -46,10 +46,11 @@ public void TestCreateActivityStart() | |||
| { | |||
| var readyToWork = Session.StartSession(ActivityClassification.Production, ReadyToWorkType.Pull, 4242); | |||
|
|
|||
| var activityStart = readyToWork.StartActivity(new DummyActivity { Process = new Process() }); | |||
| var activityStart = readyToWork.StartActivity(new DummyActivity { Process = new Process { Id = 4242 } }); | |||
There was a problem hiding this comment.
Why this change and is the UnknownActivityAborted tested somewhere?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ports: #95