-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Method to Test Whether Csv Will Be Affected by Php9 #4189
Merged
Merged
Commits on Oct 9, 2024
-
Method to Test Whether Csv Will Be Affected by Php9
See PHPOffice#4161. The best way to future-proof is to set the escape character to null string, and set testAutoDetect to false before reading. However, depending on the file being read, this may lead to different results than expected. This will be unavoidable because Php itself will change. This PR adds a new static method `affectedByPhp9` to Csv Reader. This can be used to identify in advance whether an input file will be affected by the changes. This will allow users to identify problems in advance, and prepare for how they might be handled.
Configuration menu - View commit details
-
Copy full SHA for 545b098 - Browse repository at this point
Copy the full SHA 545b098View commit details
Commits on Oct 11, 2024
-
Configuration menu - View commit details
-
Copy full SHA for f981ef9 - Browse repository at this point
Copy the full SHA f981ef9View commit details
Commits on Oct 13, 2024
-
Configuration menu - View commit details
-
Copy full SHA for d16407b - Browse repository at this point
Copy the full SHA d16407bView commit details -
Configuration menu - View commit details
-
Copy full SHA for dae5077 - Browse repository at this point
Copy the full SHA dae5077View commit details
Commits on Oct 14, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 333cb21 - Browse repository at this point
Copy the full SHA 333cb21View commit details -
I don't get it. Phpstan should pass this statement in Php8.3, but doesn't.
Configuration menu - View commit details
-
Copy full SHA for 748ef0a - Browse repository at this point
Copy the full SHA 748ef0aView commit details
Commits on Oct 15, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 753732b - Browse repository at this point
Copy the full SHA 753732bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 75ccdb0 - Browse repository at this point
Copy the full SHA 75ccdb0View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.