Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Method to Test Whether Csv Will Be Affected by Php9 #4189

Merged
merged 8 commits into from
Oct 15, 2024

Commits on Oct 9, 2024

  1. Method to Test Whether Csv Will Be Affected by Php9

    See PHPOffice#4161. The best way to future-proof is to set the escape character to null string, and set testAutoDetect to false before reading. However, depending on the file being read, this may lead to different results than expected. This will be unavoidable because Php itself will change. This PR adds a new static method `affectedByPhp9` to Csv Reader. This can be used to identify in advance whether an input file will be affected by the changes. This will allow users to identify problems in advance, and prepare for how they might be handled.
    oleibman committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    545b098 View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2024

  1. Minor Tweak

    oleibman committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    f981ef9 View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2024

  1. Make guessEncodingBom Public

    It can be used elsewhere.
    oleibman committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    d16407b View commit details
    Browse the repository at this point in the history
  2. Minor Tweak

    oleibman committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    dae5077 View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2024

  1. Eliminate Misleading Comment

    oleibman committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    333cb21 View commit details
    Browse the repository at this point in the history
  2. Restore Comment

    I don't get it. Phpstan should pass this statement in Php8.3, but doesn't.
    oleibman committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    748ef0a View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2024

  1. Configuration menu
    Copy the full SHA
    753732b View commit details
    Browse the repository at this point in the history
  2. Update CHANGELOG.md

    oleibman authored Oct 15, 2024
    Configuration menu
    Copy the full SHA
    75ccdb0 View commit details
    Browse the repository at this point in the history