Fancy Posts #39

lishaduck · 2024-10-17T21:42:47Z

Thanks for contributing!
Provide a description of your changes below and a general summary in the title.
Please look at the following checklist to ensure that your PR can be accepted quickly:

Once you've read over these comments, you should delete them.

Description

Describe your changes in a sentence or two.

This PR...

Which issue does this close?
If none, quickly write up a more detailed issue so any non-development-related discussion can go there.

Closes: #issue

CC: @MattsAttack

Type of Change

Delete all non-applicable categories.

✨ New feature
🐛 Bug fix
💥 Breaking change
📝 Documentation
♻️ Code refactor
🎨 Style
⚡️ Performance improvements
🧹 Reduce tech debt
🔥 Remove obsolete, unused things
🧪 Test
💚 CI
🛠️ Build configuration change
⏪️ Revert
🗑️ Chore

Checklist

Before submitting the PR, please make sure you do the following:

Read the Contributing Guidelines.
Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
Fill out this template.
Log your hours.
Check that commits follow the Angular commit convention, more or less.
Ideally, include relevant tests that fail without this PR but pass with it (if applicable).

Tested on

What device(s) have you tested this on?
Delete all non-applicable examples.

CI
macOS 14
Ubuntu 24.04
Windows 10
etc.

codecov · 2024-10-18T05:39:59Z

Codecov Report

Attention: Patch coverage is 32.60870% with 186 lines in your changes missing coverage. Please review.

Project coverage is 37.36%. Comparing base (45544f5) to head (7152729).
Report is 2 commits behind head on main.

Files with missing lines	Patch %	Lines
.../lib/src/features/home/presentation/home/post.dart	55.17%	39 Missing ⚠️
...rc/features/auth/presentation/auth/login_page.dart	0.00%	31 Missing ⚠️
...ttings/presentation/preferences/settings_page.dart	17.64%	28 Missing ⚠️
packages/app/lib/src/utils/hooks.dart	0.00%	25 Missing ⚠️
packages/app/lib/src/app/wrapper_page.dart	0.00%	24 Missing ⚠️
...ib/src/features/home/application/feed_service.dart	15.38%	11 Missing ⚠️
.../src/features/map/presentation/items/map_page.dart	0.00%	10 Missing ⚠️
...pp/lib/src/features/home/data/post_repository.dart	0.00%	9 Missing ⚠️
...ib/src/features/auth/application/auth_service.dart	33.33%	4 Missing ⚠️
...c/features/auth/presentation/auth/signup_page.dart	0.00%	3 Missing ⚠️
... and 2 more

Files with missing lines	Coverage Δ
packages/app/lib/src/app/app.dart	`4.54% <ø> (ø)`
packages/app/lib/src/app/router.dart	`70.45% <100.00%> (+1.40%)`	⬆️
.../src/features/home/application/avatar_service.dart	`100.00% <100.00%> (ø)`
.../lib/src/features/home/data/avatar_repository.dart	`100.00% <100.00%> (ø)`
.../app/lib/src/features/home/domain/post_entity.dart	`0.00% <ø> (ø)`
.../lib/src/features/home/presentation/home/feed.dart	`100.00% <100.00%> (ø)`
...ures/home/presentation/home/feed_routing_page.dart	`100.00% <100.00%> (ø)`
...rc/features/home/application/location_service.dart	`75.00% <50.00%> (-25.00%)`	⬇️
packages/app/lib/src/utils/design.dart	`50.00% <50.00%> (ø)`
...c/features/auth/presentation/auth/signup_page.dart	`0.00% <0.00%> (ø)`
... and 9 more

... and 1 file with indirect coverage changes

lishaduck · 2024-10-18T15:21:51Z

@MattsAttack, you pushed a rebase instead of force pushing, so I had to clean it up.
Run git reset origin/fancy-posts.

MattsAttack · 2024-10-18T16:39:08Z

My bad

lishaduck · 2024-10-18T16:40:53Z

My bad

Oh, and I did it wrong myself. Give me a few minutes.

lishaduck · 2024-10-18T16:49:31Z

Ok, you can run git reset --hard origin/fancy-posts now. Keep in mind that it'll wipe everything, so make sure there's nothing unstaged. If there is, memorize it 😉

packages/app/lib/src/features/home/presentation/home/post.dart

MattsAttack · 2024-10-18T19:21:17Z

@lishaduck I believe there's an issue with the app not requesting the users location and then not loading in the local feed. The pop up to request location only pops up sometimes on web and if doesn't theres no way to load in the local feed

lishaduck · 2024-10-18T19:26:40Z

Might be fixed with #44?

lishaduck · 2024-10-20T20:58:16Z

packages/app/lib/src/features/home/presentation/home/feed_routing_page.dart

+
+  @override
+  Widget build(BuildContext context, WidgetRef ref) {
+    return AutoTabsScaffold(


Can we use AutoTabsRouter.tabBar (and no scaffold?)

packages/app/lib/src/features/home/presentation/home/post.dart

lishaduck · 2024-10-20T21:05:26Z

packages/app/lib/src/features/home/presentation/home/post.dart

+        post.timestamp.timeZoneOffset; // Duration values are negative
+    int timeValue;
+    String timePostValue;
+    if (timeSincePost.inDays < -364) {


When is it less than a negative? This is a bit confusing. Also, you ought to be able to use a switch here, which is nice. You can't usually do that.

I just changed how this worked. Its a positive difference now

packages/app/lib/src/features/home/presentation/home/post.dart

packages/app/lib/src/features/home/data/post_repository.dart

MattsAttack · 2024-10-20T21:29:21Z

@lishaduck how should I go about getting a username from a user id?

lishaduck · 2024-10-20T21:47:33Z

@lishaduck how should I go about getting a username from a user id?

For security reasons you, erm, can't. I spent a lot of time looking into it, and it looks like you'd need to a) write a server function, or b) store a user-id => preferred name mapping in a new db collection, which would be annoying.
I pitched it as being anonymous for that reason in the script.

MattsAttack · 2024-10-20T21:51:46Z

For security reasons you, erm, can't.

What if I just added an attribute to posts that stores the person who created its user name? That should be pretty simple.

lishaduck · 2024-10-20T21:54:08Z

For security reasons you, erm, can't.

What if I just added an attribute to posts that stores the person who created its user name? That should be pretty simple.

Hm. That'd be fine assuming that we don't allow changing your display name.

MattsAttack · 2024-10-20T21:56:01Z

Hm. That'd be fine assuming that we don't allow changing your display name.

That's true. But if they were to change it we could update the value of the posts the users made in the data base with their new user name. It's not the best but its probably better than sending an api call every time you load a post

lishaduck · 2024-10-20T22:03:36Z

That's true. But if they were to change it we could update the value of the posts the users made in the data base with their new user name. It's not the best but its probably better than sending an api call every time you load a post

It would take a while and we could cache it, but yeah, I think it'd be fine. Just write it :)

MattsAttack · 2024-10-20T22:05:41Z

It would take a while and we could cache it, but yeah, I think it'd be fine. Just write it :)

Ai ai captain

lishaduck · 2024-10-21T00:17:34Z

packages/app/lib/src/features/home/presentation/home/post.dart

+  Future<MemoryImage> getAvatar(Avatars avatarService) async {
+    return MemoryImage(await avatarService.getInitials(name: post.authorName));
+  }


This fetches them every frame. (well, flutter and images are weird, it might just be per every time it gets a new render, but still, should be globally memoized)

I forgot to share this with you: https://github.com/PSDTools/app/blob/2b793de1d796cb215a91a2b1767d95fbb80481cc/lib/features/auth/data/avatar_repository.dart
https://github.com/PSDTools/app/blob/2b793de1d796cb215a91a2b1767d95fbb80481cc/lib/features/auth/data/auth_repository.dart

I've been wanting to add a drawer, I might just copy all this code over.

Co-authored-by: Matthew Wasser <[email protected]>

MattsAttack · 2024-10-23T01:52:28Z

Oh nice! Did you fix the local world tab background?

lishaduck · 2024-10-23T01:53:00Z

Oh nice! Did you fix the local world tab background?

Yup! It was easy-peasy once I'd figured out the issue.

MattsAttack · 2024-10-23T01:55:54Z

awesome sauce

MattsAttack · 2024-11-20T03:53:50Z

@lishaduck could you help me debug the windows build sometime? The rebrand broke it due to naming issues. It's currently crashing and returning:
CMake Error at runner/CMakeLists.txt:9 (add_executable):
The target name "Town Talk" is reserved or not valid for certain CMake
features, such as generator expressions, and may result in undefined
behavior.

CMake Error at CMakeLists.txt:41 (target_compile_features):
Cannot specify compile features for target "Town Talk" which is not built
by this project.
Call Stack (most recent call first):
runner/CMakeLists.txt:21 (apply_standard_settings)

CMake Error at runner/CMakeLists.txt:24 (target_compile_definitions):
Cannot specify compile definitions for target "Town Talk" which is not
built by this project.

CMake Error at runner/CMakeLists.txt:25 (target_compile_definitions):
Cannot specify compile definitions for target "Town Talk" which is not
built by this project.

CMake Error at runner/CMakeLists.txt:26 (target_compile_definitions):
Cannot specify compile definitions for target "Town Talk" which is not
built by this project.

CMake Error at runner/CMakeLists.txt:27 (target_compile_definitions):
Cannot specify compile definitions for target "Town Talk" which is not
built by this project.

CMake Error at runner/CMakeLists.txt:28 (target_compile_definitions):
Cannot specify compile definitions for target "Town Talk" which is not
built by this project.

CMake Error at runner/CMakeLists.txt:31 (target_compile_definitions):
Cannot specify compile definitions for target "Town Talk" which is not
built by this project.

CMake Error at runner/CMakeLists.txt:35 (target_link_libraries):
Cannot specify link libraries for target "Town Talk" which is not built by
this project.

Error: Unable to generate build files

Exited (1).

I figured out that one of the issues is your binary name has spaced but not it's giving this error 20 times:
CMake Error:
Error evaluating generator expression:

$<TARGET_FILE_DIR:nexus>

No target "nexus"

I'm assuming it's because the name of the app in pubspec is different. We may want to decide on a name for the TSA version and just rename everything. I've committed what I've done so far.

lishaduck · 2024-11-20T14:05:42Z

.vscode/settings.json

+  "github-actions.workflows.pinned.workflows": [
+    ".github/workflows/ci.yaml"
+  ],
+  "C_Cpp.errorSquiggles": "enabled"


What's this?

I accidentally disabled errorSquiggles so i turned them back on. I thought it was a local setting

melos.yaml

packages/app/linux/CMakeLists.txt

packages/app/windows/CMakeLists.txt

lishaduck · 2024-11-20T14:06:41Z

packages/app/windows/runner/CMakeLists.txt

@@ -6,7 +6,7 @@ project(runner LANGUAGES CXX)
 # work.
 #
 # Any new source files that you add to the application should be added here.
-add_executable(${BINARY_NAME} WIN32
+add_executable(TownTalk WIN32


Was this intentional?

Loosely. I wanted to see if it would change anything. I'll probably revert it

Co-authored-by: Eli <[email protected]> Signed-off-by: Matthew Wasser <[email protected]>

MattsAttack · 2024-11-21T03:08:10Z

@lishaduck yeah it's still returning
CMake Error:
Error evaluating generator expression:

$<TARGET_FILE_DIR:nexus>

No target "nexus"

20 times

lishaduck · 2024-11-21T14:16:26Z

@lishaduck yeah it's still returning CMake Error: Error evaluating generator expression:

Try flutter clean.

This reverts commit de4d465.

lishaduck · 2024-11-25T23:02:47Z

packages/app/lib/src/features/home/presentation/home/post.dart

+          onPressed: () {
+            if (thumbsIcon.value.icon == Icons.thumb_up_outlined) {
+              thumbsIcon.value = const Icon(Icons.thumb_up_sharp);
+            } else {
+              thumbsIcon.value = const Icon(Icons.thumb_up_outlined);
+            }
+          },


Is this meant as an animation? 🤣

maybe eventually. right now it just updates the icon of the thumb when you click it

lishaduck · 2024-11-26T19:27:48Z

packages/app/lib/src/features/home/application/feed_service.dart

-    if (cachedPost != null) return cachedPost;
+
+    if (cachedPost != null) {
+      // Updates


Amazing comment. -1

Whoops. I was to busy watching Freebird

lishaduck force-pushed the fancy-posts branch from fd55b33 to 7fb27ba Compare October 18, 2024 15:20

lishaduck force-pushed the fancy-posts branch from 7fb27ba to 4c36abe Compare October 18, 2024 16:48

lishaduck commented Oct 18, 2024

View reviewed changes

packages/app/lib/src/features/home/presentation/home/post.dart Show resolved Hide resolved

lishaduck commented Oct 20, 2024

View reviewed changes

packages/app/lib/src/features/home/presentation/home/post.dart Outdated Show resolved Hide resolved

lishaduck commented Oct 20, 2024

View reviewed changes

packages/app/lib/src/features/home/presentation/home/post.dart Outdated Show resolved Hide resolved

lishaduck commented Oct 20, 2024

View reviewed changes

packages/app/lib/src/features/home/data/post_repository.dart Outdated Show resolved Hide resolved

lishaduck commented Oct 21, 2024

View reviewed changes

lishaduck and others added 7 commits October 21, 2024 13:14

chore: extract out post widget

a13c7fc

wip

f50f851

Co-authored-by: Matthew Wasser <[email protected]>

refactor: clean

adec1de

wip

8cb58cd

wip still

d3200b9

local and world feed navigation bar

3763453

wip. updated time value in posts (need to fix difference)

aa5c11b

lishaduck linked an issue Oct 23, 2024 that may be closed by this pull request

UI design #27

Open

feat: rebrand

279dfb9

lishaduck assigned lishaduck and MattsAttack Oct 23, 2024

Attempted to debug windows build

b542f7a

lishaduck commented Nov 20, 2024

View reviewed changes

MattsAttack and others added 3 commits November 20, 2024 08:28

Update melos.yaml

5d1fa80

Co-authored-by: Eli <[email protected]> Signed-off-by: Matthew Wasser <[email protected]>

Update packages/app/linux/CMakeLists.txt

b3a9c41

Co-authored-by: Eli <[email protected]> Signed-off-by: Matthew Wasser <[email protected]>

Update packages/app/windows/CMakeLists.txt

078f905

Co-authored-by: Eli <[email protected]> Signed-off-by: Matthew Wasser <[email protected]>

MattsAttack added 2 commits November 20, 2024 21:10

revert CMake executable

5c74c51

Changed avatar implementation.

dfbe43e

MattsAttack added 7 commits November 21, 2024 11:49

fix avatar not being saved in local memory

a7ec715

wip

de4d465

Revert "wip"

f8b419a

This reverts commit de4d465.

fix: post scaling

872cdfd

Test Fixes :)

75671e4

WIP: Like button

df7062b

implement likes string list

1207487

lishaduck commented Nov 25, 2024

View reviewed changes

MattsAttack added 2 commits November 25, 2024 18:22

WIP: Likes. Need to fix getting post id in PostEntity

f36979d

fix: getting ids in post entity

780a463

lishaduck commented Nov 26, 2024

View reviewed changes

MattsAttack added 2 commits November 26, 2024 23:06

comments :)

dce045b

WIP: post likes( forgot to commit last week)

7152729

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fancy Posts #39

Fancy Posts #39

lishaduck commented Oct 17, 2024 •

edited

Loading

codecov bot commented Oct 18, 2024 •

edited

Loading

lishaduck commented Oct 18, 2024

MattsAttack commented Oct 18, 2024

lishaduck commented Oct 18, 2024

lishaduck commented Oct 18, 2024

MattsAttack commented Oct 18, 2024

lishaduck commented Oct 18, 2024

lishaduck Oct 20, 2024

lishaduck Oct 20, 2024

MattsAttack Oct 20, 2024

MattsAttack commented Oct 20, 2024

lishaduck commented Oct 20, 2024

MattsAttack commented Oct 20, 2024 •

edited

Loading

lishaduck commented Oct 20, 2024

MattsAttack commented Oct 20, 2024 •

edited

Loading

lishaduck commented Oct 20, 2024

MattsAttack commented Oct 20, 2024

lishaduck Oct 21, 2024

MattsAttack commented Oct 23, 2024

lishaduck commented Oct 23, 2024 •

edited

Loading

MattsAttack commented Oct 23, 2024

MattsAttack commented Nov 20, 2024

lishaduck Nov 20, 2024

MattsAttack Nov 20, 2024

lishaduck Nov 20, 2024

MattsAttack Nov 20, 2024

MattsAttack commented Nov 21, 2024

lishaduck commented Nov 21, 2024

lishaduck Nov 25, 2024

MattsAttack Nov 27, 2024

lishaduck Nov 26, 2024

MattsAttack Nov 27, 2024

Fancy Posts #39

Are you sure you want to change the base?

Fancy Posts #39

Conversation

lishaduck commented Oct 17, 2024 • edited Loading

Description

Type of Change

Checklist

Tested on

codecov bot commented Oct 18, 2024 • edited Loading

Codecov Report

lishaduck commented Oct 18, 2024

MattsAttack commented Oct 18, 2024

lishaduck commented Oct 18, 2024

lishaduck commented Oct 18, 2024

MattsAttack commented Oct 18, 2024

lishaduck commented Oct 18, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

MattsAttack commented Oct 20, 2024

lishaduck commented Oct 20, 2024

MattsAttack commented Oct 20, 2024 • edited Loading

lishaduck commented Oct 20, 2024

MattsAttack commented Oct 20, 2024 • edited Loading

lishaduck commented Oct 20, 2024

MattsAttack commented Oct 20, 2024

Choose a reason for hiding this comment

MattsAttack commented Oct 23, 2024

lishaduck commented Oct 23, 2024 • edited Loading

MattsAttack commented Oct 23, 2024

MattsAttack commented Nov 20, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

MattsAttack commented Nov 21, 2024

lishaduck commented Nov 21, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lishaduck commented Oct 17, 2024 •

edited

Loading

codecov bot commented Oct 18, 2024 •

edited

Loading

MattsAttack commented Oct 20, 2024 •

edited

Loading

MattsAttack commented Oct 20, 2024 •

edited

Loading

lishaduck commented Oct 23, 2024 •

edited

Loading