Apple Delegated Delivery UI updates #1139
Conversation
| <% end %> | ||
| <%= form.label :apple_show_id, "Apple Show ID" %> | ||
| </div> | ||
| </div> |
There was a problem hiding this comment.
It seems that we almost have a two step process here. Upload the key, and then select and connect the show. Another way to say it is that the show drowdown will be empty until the key is populated.
Should we hide the apple config stuff (apple show id, sync blocs rss etc) until the key is uploaded?
If we did that, then the show's paged query could serve as a quick validation of the key as well.
There was a problem hiding this comment.
Yeah, I thought about that, and I was torn on whether or not it was worth it - in the case where a user already knows the apple id, we don't need to make it two steps, and since almost all shows will have an apple id whether they have a subscription channel or not, I didn't want to prevent using a known value until it could be looked up.
I'll try making this conditional/two-step, and see how it goes!
There was a problem hiding this comment.
Another problem with this design is you can't delete or replace the API keys.
| @@ -6,38 +6,66 @@ | |||
| <div class="card-body" data-controller="apple-key"> | |||
| <div class="mb-4"> | |||
| <p><%= t(".description") %></p> | |||
| <a href="https://help.prx.org/hc/en-us/articles/26602803552155-Setting-up-Apple-Podcast-Subscriptions-with-Apple-Delegated-Delivery"><%= t(".guide_link") %></a> | |||
| <%= t(".guide_link").html_safe %> | |||
There was a problem hiding this comment.
this is a cosmetic change- help urls should not be embedded in the code, moved it to the translations, and allowed a link with html_safe
| </div> | ||
| <%= form.fields_for :apple_config do |config_form| %> | ||
| <%= config_form.fields_for :key do |key_fields| %> | ||
| <% unless config_form.object.persisted? %> | ||
| <%= key_fields.file_field :key_file, class: "mb-4 form-control", accept: ".p8, .pem", data: {action: "apple-key#convertFileToKey"} %> | ||
| <%= key_fields.file_field :key_file, class: "mb-4 form-control", accept: ".p8, .pem", data: {action: "apple-key#convertFileToKey"}, required: true %> |
There was a problem hiding this comment.
now this is required so you can't create the apple feed without adding a file
| <%= key_fields.hidden_field :provider_id, data: {apple_key_target: "provider"} %> | ||
| <%= key_fields.hidden_field :key_id, data: {apple_key_target: "key"} %> | ||
| <% end %> | ||
| <% if config_form.object.persisted? %> |
There was a problem hiding this comment.
within this form, also hides all the other fields until a valid key is uploaded and saved
| @@ -779,10 +782,13 @@ en: | |||
| ad_zones: Control the types of ads that should be stitched into episodes in this feed. | |||
| form_apple_config: | |||
| title: Apple Subscriptions | |||
| description: In order to publish episodes through Apple's Podcast Connect API, ensure you've delegated access to the PRX account in Podcast Connect. | |||
There was a problem hiding this comment.
this isn't true - you need an API key from whatever apple account, doesn't have to be the PRX account
| Feeds::AppleSubscription.all.each do |feed| | ||
| apple_id = feed.apple_sync_log&.external_id | ||
| feed.update_attribute!(:apple_show_id, apple_id) | ||
| end |
There was a problem hiding this comment.
now this migration adds the apple show id, and fills it from the sync log entries
also supports locking feeds down, so this info can't be changed via the UI: