Skip to content
This repository has been archived by the owner on May 31, 2024. It is now read-only.

Rewrite inverse methods of model estimation #189

Merged
Show file tree
Hide file tree
Changes from 41 commits
Commits
Show all changes
376 commits
Select commit Hold shift + click to select a range
344d860
refactor(_fir_filter_diag): fix clipping after breaking it
BjoernLudwigPTB Oct 13, 2021
4c7b2d5
refactor(test_reveal_difference_between_current_and_former_FIRuncFilt…
BjoernLudwigPTB Oct 13, 2021
44da4b0
refactor(test_reveal_difference_between_current_and_former_FIRuncFilt…
BjoernLudwigPTB Oct 13, 2021
8063923
refactor(test_compare_invLSFIR_unc_to_invLSFIR): mark test as slow
BjoernLudwigPTB Oct 13, 2021
a8ee488
refactor(test_compose_DFT_and_iDFT_with_full_covariance): mark as slow
BjoernLudwigPTB Oct 13, 2021
dbaebea
refactor(test_reveal_bug_in_dft_deconv_up_to_1_9): mark as slow
BjoernLudwigPTB Oct 13, 2021
b94e2b9
refactor(test_fit_som_with_nonsquare_UH): rename from unsquare to non…
BjoernLudwigPTB Oct 13, 2021
486fb01
refactor(test_fit_som_with_nonint_MCruns): speed up test by replacing…
BjoernLudwigPTB Oct 13, 2021
594fb15
refactor(_normalize_vector_or_matrix): replace min call on array by n…
BjoernLudwigPTB Oct 13, 2021
fdf08fd
refactor(conf.py): replace http in numpy link by https
BjoernLudwigPTB Oct 13, 2021
04852e5
chore(hypothesis): introduce new examples
BjoernLudwigPTB Oct 13, 2021
54dada0
refactor(invLSFIR): improve docstring
BjoernLudwigPTB Oct 13, 2021
f72d107
refactor(invLSFIR): correct printed message
BjoernLudwigPTB Oct 13, 2021
344fcbf
refactor(invLSFIR_unc): introduce type hints
BjoernLudwigPTB Oct 13, 2021
199e8fa
refactor(invLSFIR_unc): improve docstrings
BjoernLudwigPTB Oct 13, 2021
e447d14
refactor(invLSFIR_unc): correct printed message and improve implement…
BjoernLudwigPTB Oct 13, 2021
d3f5c4c
refactor(invLSFIR_uncMC): correct printed message and improve impleme…
BjoernLudwigPTB Oct 13, 2021
9d77bd7
refactor(invLSFIR_uncMC): introduce type hints
BjoernLudwigPTB Oct 13, 2021
d832242
refactor(invLSFIR_uncMC): improve docstrings
BjoernLudwigPTB Oct 13, 2021
19b0e65
wip(test_compare_invLSFIR_unc_to_invLSFIR_uncMC): introduce compariso…
BjoernLudwigPTB Oct 13, 2021
704832f
chore(test_LSFIR): introduce new examples
BjoernLudwigPTB Oct 13, 2021
96bec7d
Merge branch 'prepare_major_release_2.0.0' into fix/#147_rewrite_inve…
BjoernLudwigPTB Oct 13, 2021
94fe105
wip(test_FIRuncFilter_legacy_comparison): adjust bounds to pass test
BjoernLudwigPTB Oct 14, 2021
e7423d7
chore(conftest): improve dimension strategy
BjoernLudwigPTB Oct 14, 2021
86c0dca
refactor(test_LSFIR): rename N to filter_order
BjoernLudwigPTB Oct 14, 2021
f6bd638
refactor(test_compare_invLSFIR_unc_to_invLSFIR_uncMC): restrict filte…
BjoernLudwigPTB Oct 14, 2021
b0194dd
refactor(test_compare_invLSFIR_unc_to_invLSFIR_uncMC): adjust bounds …
BjoernLudwigPTB Oct 14, 2021
ac77306
chore(hypothesis): introduce new examples
BjoernLudwigPTB Oct 14, 2021
1abe0f9
chore(conftest): repair dimension strategy
BjoernLudwigPTB Oct 14, 2021
a197d84
wip(test_usual_call_LSFIR): introduce reasonable bounds for filter di…
BjoernLudwigPTB Oct 14, 2021
89af10a
chore(conftest): really repair dimension strategy
BjoernLudwigPTB Oct 14, 2021
0d99114
Merge branch 'prepare_major_release_2.0.0' into fix/#147_rewrite_inve…
BjoernLudwigPTB Oct 14, 2021
47a8d23
refactor(random_array): remove intermediate variable definition
BjoernLudwigPTB Oct 15, 2021
783bdd9
chore(hypothesis): introduce new failing example for test_FIRuncFilte…
BjoernLudwigPTB Oct 15, 2021
8a737d6
wip(test_FIRuncFilter_legacy_comparison): adjust bounds to pass test …
BjoernLudwigPTB Oct 15, 2021
96bbdc8
Merge branch 'master' into fix/#147_rewrite_inverse_methods_of_model_…
BjoernLudwigPTB Oct 15, 2021
a45d1d6
wip(test_MC_non_negative_main_diagonal_covariance): transfer test fro…
BjoernLudwigPTB Oct 15, 2021
376228b
wip(test_propagate_filter): replace plot hacks by plot_vectors_and_co…
BjoernLudwigPTB Oct 15, 2021
7d9c67f
wip(test_propagate_filter): split tests for better feedback
BjoernLudwigPTB Oct 15, 2021
c55c6b1
chore(hypothesis): introduce new examples
BjoernLudwigPTB Oct 15, 2021
1084fbc
build(deps): recompile dependencies
BjoernLudwigPTB Oct 15, 2021
14c722c
chore(hypothesis): update example database
BjoernLudwigPTB Oct 15, 2021
d2aec71
wip(reference arrays): remove one accidentally added reference
BjoernLudwigPTB Oct 15, 2021
87270cb
refactor(IIRuncFilter): replace string comparison via 'is not' by ope…
BjoernLudwigPTB Oct 15, 2021
1f702d5
refactor(IIRuncFilter): exchange exception by warning as intended
BjoernLudwigPTB Oct 15, 2021
8d06fce
wip(test_IIRuncFilter_raises_warning_for_kind_not_diag_with_scalar_co…
BjoernLudwigPTB Oct 15, 2021
145f2ed
Merge branch 'prepare_major_release_2.0.0' into fix/#147_rewrite_inve…
BjoernLudwigPTB Oct 15, 2021
ec83475
refactor(test_FIRuncFilter_MC_uncertainty_comparison): enable Monte C…
BjoernLudwigPTB Oct 15, 2021
2fadb1d
refactor(test_FIRuncFilter_legacy_comparison): adjust bounds to pass …
BjoernLudwigPTB Oct 15, 2021
2714522
chore(hypothesis): insert new failing examples for test_FIRuncFilter_…
BjoernLudwigPTB Oct 17, 2021
4fc41c7
wip(test_FIRuncFilter_legacy_comparison): adjust bounds to pass test …
BjoernLudwigPTB Oct 17, 2021
a6f5318
refactor(test_compare_invLSFIR_unc_to_invLSFIR): introduce dimension …
BjoernLudwigPTB Oct 19, 2021
62603fa
refactor(test_FIRuncFilter_legacy_comparison): adjust bounds to pass …
BjoernLudwigPTB Oct 19, 2021
4d703ac
refactor(test_demonstrate_second_order_model_fitting): introduce prin…
BjoernLudwigPTB Oct 19, 2021
2cc7395
chore(hypothesis): introduce new failing example for test_FIRuncFilte…
BjoernLudwigPTB Oct 19, 2021
f8d9b84
wip(test_FIRuncFilter_legacy_comparison): adjust bounds to pass test …
BjoernLudwigPTB Oct 19, 2021
6b7092a
Merge branch 'prepare_major_release_2.0.0' into fix/#147_rewrite_inve…
BjoernLudwigPTB Oct 19, 2021
bd6f40a
wip(conftest): introduce new strategy useful for weights
BjoernLudwigPTB Oct 19, 2021
95d55e0
wip(invLSFIR_unc): fix dimension check for weights
BjoernLudwigPTB Oct 19, 2021
e768683
wip(invLSFIR_uncMC): fix dimension check for weights
BjoernLudwigPTB Oct 19, 2021
5732b18
wip(fit_filter): start refactoring of all LSFIR functions based on in…
BjoernLudwigPTB Oct 19, 2021
de6cbbe
wip(test_LSFIR): improve and extend test suite
BjoernLudwigPTB Oct 19, 2021
f0b8fdf
wip(test_FIRuncFilter_legacy_comparison): introduce printing to avoid…
BjoernLudwigPTB Oct 20, 2021
3dc4aae
refactor(test_LSFIR): avoid overwriting module level fixtures
BjoernLudwigPTB Oct 20, 2021
4441e54
wip(test_FIRuncFilter_legacy_comparison): adjust bounds to pass test …
BjoernLudwigPTB Oct 20, 2021
87a70fc
wip(LSFIR): fix a future error calling np.linalg.lstsq by introducing…
BjoernLudwigPTB Oct 20, 2021
922bd62
wip(_validate_vector_and_corresponding_uncertainties_dimensions): ren…
BjoernLudwigPTB Oct 20, 2021
d498fac
wip(_compute_omega_equals_two_pi_times_frequencies_divided_by_samplin…
BjoernLudwigPTB Oct 20, 2021
073ba64
refactor(invLSFIR): remove unneeded code
BjoernLudwigPTB Oct 20, 2021
2a4dc41
refactor(_compute_x): reduce redundancy
BjoernLudwigPTB Oct 20, 2021
e2b86fb
refactor(_validate_length_of_h): reduce redundancy
BjoernLudwigPTB Oct 20, 2021
4ab4793
refactor(invLSFIR_uncMC): rename res to residuals
BjoernLudwigPTB Oct 20, 2021
4184dd6
refactor(invLSFIR_uncMC): introduce printing rms on verbose=True
BjoernLudwigPTB Oct 20, 2021
3179805
wip(test_usual_call_invLSFIR_uncMC): introduce test for any set of va…
BjoernLudwigPTB Oct 20, 2021
ba0fc06
refactor(test_FIRuncFilter_legacy_comparison): adjust bounds to pass …
BjoernLudwigPTB Oct 20, 2021
e07487e
Merge branch 'master' into fix/#147_rewrite_inverse_methods_of_model_…
BjoernLudwigPTB Oct 20, 2021
1adef6f
refactor(test_FIRuncFilter_legacy_comparison): adjust bounds to pass …
BjoernLudwigPTB Oct 20, 2021
8377cdd
chore(hypothesis): remove unneeded examples
BjoernLudwigPTB Oct 20, 2021
0562e26
wip(test_FIRuncFilter_MC_uncertainty_comparison): improve test by res…
BjoernLudwigPTB Oct 20, 2021
78dffd2
chore(hypothesis): remove unneeded examples
BjoernLudwigPTB Oct 20, 2021
eadd1eb
refactor(test_usual_call_invLSFIR_uncMC): introduce printing to avoid…
BjoernLudwigPTB Oct 20, 2021
90f5e88
refactor(test_FIRuncFilter_legacy_comparison): adjust bounds to pass …
BjoernLudwigPTB Oct 20, 2021
9c1167e
chore(hypothesis): introduce new examples
BjoernLudwigPTB Oct 20, 2021
9cf2e53
chore(hypothesis): introduce new failing example for test_FIRuncFilte…
BjoernLudwigPTB Oct 20, 2021
7397a70
wip(test_usual_call_invLSFIR_uncMC): introduce health check suppresion
BjoernLudwigPTB Oct 20, 2021
85ccbe0
refactor(test_LSFIR): improve weight strategy
BjoernLudwigPTB Oct 20, 2021
27d3d26
wip(test_LSFIR): introduce tests to provoke exceptions for wrong weights
BjoernLudwigPTB Oct 20, 2021
9521200
refactor(fit_filter): introduce _compute_omega_equals_two_pi_times_fr…
BjoernLudwigPTB Oct 20, 2021
b144e9a
refactor(invLSFIR_uncMC): shorten all unambiguous names and streamlin…
BjoernLudwigPTB Oct 20, 2021
d05623b
refactor(invLSFIR_uncMC): correct one error message
BjoernLudwigPTB Oct 20, 2021
1211d7b
refactor(invLSFIR_uncMC): remove unneeded comments
BjoernLudwigPTB Oct 20, 2021
c70cebe
chore(hypothesis): introduce new examples
BjoernLudwigPTB Oct 20, 2021
e1bdc5e
Merge branch 'prepare_major_release_2.0.0' into fix/#147_rewrite_inve…
BjoernLudwigPTB Oct 20, 2021
285e8f7
wip(test_invLSFIR_uncMC_with_wrong_len_weights): introduce printing t…
BjoernLudwigPTB Oct 20, 2021
98393b1
chore(hypothesis): update examples
BjoernLudwigPTB Oct 20, 2021
383c904
refactor(invLSFIR_uncMC): reorder parameter checks to speed up in cas…
BjoernLudwigPTB Oct 20, 2021
e600338
refactor(test_fit_som_with_zero_frequency_response_but_without_MCruns…
BjoernLudwigPTB Oct 20, 2021
1233c5a
refactor(test_usual_call_invLSFIR_uncMC): mark as slow
BjoernLudwigPTB Oct 20, 2021
5d19838
chore(hypothesis): update examples
BjoernLudwigPTB Oct 20, 2021
5836e73
refactor(test_invLSFIR_uncMC_with_wrong_len_weights): mark as slow
BjoernLudwigPTB Oct 20, 2021
1b69e18
refactor(fit_filter): further shorten names
BjoernLudwigPTB Oct 21, 2021
6a59c98
refactor(invLSFIR_uncMC): improve error checking and its readability
BjoernLudwigPTB Oct 21, 2021
5f06da2
refactor(invLSFIR_unc): introduce inv parameter
BjoernLudwigPTB Oct 21, 2021
34dd26e
refactor(invLSFIR_unc): harmonize rms printing with invLSFIR_uncMC
BjoernLudwigPTB Oct 21, 2021
fa5eaa8
refactor(invLSFIR_uncMC): streamline mc implementation
BjoernLudwigPTB Oct 21, 2021
38ddd67
refactor(test_LSFIR): improve error checking tests with regexes
BjoernLudwigPTB Oct 21, 2021
921ba1f
refactor(test_LSFIR): introduce more tests
BjoernLudwigPTB Oct 21, 2021
9fe222e
chore(hypothesis): update examples
BjoernLudwigPTB Oct 21, 2021
8a78f6d
wip(test_compare_invLSFIR_uncMC_to_invLSFIR): introduce new important…
BjoernLudwigPTB Oct 21, 2021
2376c54
wip(invLSFIR_uncMC): change default parameter setting to expected value
BjoernLudwigPTB Oct 21, 2021
d3b99c5
wip(test_compare_invLSFIR_uncMC_to_LSFIR): introduce new important test
BjoernLudwigPTB Oct 21, 2021
4c01cfc
chore(hypothesis): update examples
BjoernLudwigPTB Oct 21, 2021
d8c9151
refactor(test_LSFIR): shorten names
BjoernLudwigPTB Oct 21, 2021
46654c4
refactor(test_LSFIR): introduce mypy casts
BjoernLudwigPTB Oct 21, 2021
159e9de
wip(test_LSFIR): repair test regexes after refactoring
BjoernLudwigPTB Oct 22, 2021
6a495be
wip(test_not_implemented_invLSFIR_unc): remove one unneeded variable …
BjoernLudwigPTB Oct 22, 2021
c512bcc
wip(test_LSFIR): introduce new exceptions of sanity checks for new se…
BjoernLudwigPTB Oct 22, 2021
2f33431
wip(invLSFIR_uncMC): introduce new parameter trunc_svd_tol
BjoernLudwigPTB Oct 22, 2021
6d3e95c
wip(invLSFIR_uncMC): improve docstring
BjoernLudwigPTB Oct 22, 2021
f7c6cbe
wip(invLSFIR_uncMC): improve printed message in beginning of processing
BjoernLudwigPTB Oct 22, 2021
a908222
wip(invLSFIR_unc): improve error message for NotImplementedError
BjoernLudwigPTB Oct 22, 2021
4de2581
wip(invLSFIR_uncMC): remove runs and work with mc_runs directly
BjoernLudwigPTB Oct 22, 2021
e7530e1
wip(invLSFIR_uncMC): introduce more sanity checks
BjoernLudwigPTB Oct 22, 2021
46d475a
chore(hypothesis): update examples
BjoernLudwigPTB Oct 22, 2021
25de4ea
refactor(test_not_implemented_invLSFIR_uncMC): reduce redundancy by i…
BjoernLudwigPTB Oct 25, 2021
eceb730
chore(hypothesis): update examples
BjoernLudwigPTB Oct 25, 2021
e869566
refactor(invLSFIR): remove unneeded variable
BjoernLudwigPTB Oct 25, 2021
db8fe4d
refactor(test_compare_invLSFIR_unc_to_invLSFIR): remove unneeded vari…
BjoernLudwigPTB Oct 25, 2021
7310f1e
refactor(test_FIRuncFilter_for_correct_dimension_of_y): remove unneed…
BjoernLudwigPTB Oct 25, 2021
3dd8fac
refactor(test_FIRuncFilter_MC_uncertainty_comparison): introduce sign…
BjoernLudwigPTB Oct 25, 2021
fb8a89c
refactor(test_FIRuncFilter_legacy_comparison): replace a ndarray.max(…
BjoernLudwigPTB Oct 25, 2021
b621d16
chore(hypothesis): update examples
BjoernLudwigPTB Oct 25, 2021
80039be
refactor(test_FIRuncFilter_MC_uncertainty_comparison): remove signal …
BjoernLudwigPTB Oct 26, 2021
386d640
Revert "refactor(test_FIRuncFilter_MC_uncertainty_comparison): remove…
BjoernLudwigPTB Oct 26, 2021
5b43bfe
refactor(test_FIRuncFilter_MC_uncertainty_comparison): adjust bounds …
BjoernLudwigPTB Oct 26, 2021
3f4f9af
chore(hypothesis): update examples
BjoernLudwigPTB Oct 26, 2021
8348ffa
refactor(test_FIRuncFilter_MC_uncertainty_comparison): adjust bounds …
BjoernLudwigPTB Oct 26, 2021
0a1ec53
chore(hypothesis): update examples
BjoernLudwigPTB Oct 26, 2021
a7cb82e
refactor(test_FIRuncFilter_MC_uncertainty_comparison): adjust bounds …
BjoernLudwigPTB Oct 26, 2021
91b34bc
refactor(fit_filter): introduce _assemble_real_imag_from_complex
BjoernLudwigPTB Oct 26, 2021
6218cbb
refactor(fit_filter): introduce _PropagationMethod and clarify _valid…
BjoernLudwigPTB Oct 26, 2021
0981cc3
refactor(fit_filter): introduce _draw_monte_carlo_samples and _assemb…
BjoernLudwigPTB Oct 26, 2021
33024b0
refactor(LSFIR): improve implementation corresponding to other refact…
BjoernLudwigPTB Oct 26, 2021
32000a1
refactor(invLSFIR): improve implementation corresponding to other ref…
BjoernLudwigPTB Oct 26, 2021
b97c2b8
refactor(invLSFIR_incMC): improve rmse computation
BjoernLudwigPTB Oct 26, 2021
ec1ef9b
refactor(test_compare_invLSFIR_uncMC_with_zero_uncertainties_to_LSFIR…
BjoernLudwigPTB Oct 26, 2021
1dffa7f
refactor(test_compare_invLSFIR_uncMC_to_invLSFIR): correct number of …
BjoernLudwigPTB Oct 26, 2021
9a90a6e
refactor(test_LSFIR.py): introduce more tests
BjoernLudwigPTB Oct 26, 2021
5ea7387
chore(test_LSFIR): mark some more tests as slow
BjoernLudwigPTB Oct 26, 2021
0ad24fc
chore(hypothesis): update examples
BjoernLudwigPTB Oct 26, 2021
fe7d5fa
refactor(test_compare_invLSFIR_uncMC_with_zero_uncertainty_and_withou…
BjoernLudwigPTB Oct 26, 2021
62d14fe
refactor(test_FIRuncFilter_MC_uncertainty_comparison): reduce number …
BjoernLudwigPTB Oct 26, 2021
d0d530b
refactor(invLSFIR_uncMC): finalize mc and svd implementation
BjoernLudwigPTB Oct 26, 2021
adcd5f2
Revert "refactor(invLSFIR_incMC): improve rmse computation"
BjoernLudwigPTB Oct 26, 2021
516b6ce
refactor(test_LSFIR): introduce more comparison tests
BjoernLudwigPTB Oct 26, 2021
4fed07b
chore(hypothesis): update examples
BjoernLudwigPTB Oct 26, 2021
392fd72
chore(test_LSFIR): avoid overwriting a test
BjoernLudwigPTB Oct 26, 2021
b3989e7
refactor(test_compare_invLSFIR_uncMC_with_zero_uncertainty_and_withou…
BjoernLudwigPTB Oct 26, 2021
05e8f12
refactor(fit_filter): reuse _assemble_real_imag_from_complex in _comp…
BjoernLudwigPTB Oct 27, 2021
34e1e43
Revert "refactor(fit_filter): reuse _assemble_real_imag_from_complex …
BjoernLudwigPTB Oct 27, 2021
e01bad0
refactor(fit_filter): rename _compute_omega_equals_two_pi_times_freqs…
BjoernLudwigPTB Oct 27, 2021
e891696
refactor(test_compare_invLSFIR_uncMC_with_zero_uncertainty_to_invLSFI…
BjoernLudwigPTB Oct 27, 2021
3b78c16
refactor(test_LSFIR): introduce two more tests of invLSFIR_uncMC agai…
BjoernLudwigPTB Oct 27, 2021
dbcaf07
refactor(fit_filter): introduce _compute_delayed_filters_freq_resp_vi…
BjoernLudwigPTB Oct 27, 2021
f81c75b
refactor(fit_filter): introduce _compute_and_print_rms
BjoernLudwigPTB Oct 27, 2021
bd3f09f
refactor(fit_filter): introduce some missing type hints
BjoernLudwigPTB Oct 27, 2021
c4d6152
refactor(fit_filter): shorten some names in _fit_fir_filter_with_unce…
BjoernLudwigPTB Oct 27, 2021
ce9da48
refactor(fit_filter): change name of _validate_weights to _validate_a…
BjoernLudwigPTB Oct 27, 2021
96bdfd0
refactor(invLSFIR_uncMC): change default for inv to False
BjoernLudwigPTB Oct 27, 2021
089c942
refactor(invLSFIR_uncMC): improve docstring
BjoernLudwigPTB Oct 27, 2021
f38337e
refactor(invLSFIR): remove unneeded comments
BjoernLudwigPTB Oct 27, 2021
377b466
refactor(fit_filter): finalize refactoring of invLSFIR_uncMC
BjoernLudwigPTB Oct 27, 2021
6a7ab5b
chore(hypothesis): update examples
BjoernLudwigPTB Oct 27, 2021
35f7a4a
refactor(test_LSIIR): rename test_model_estimation.py to test_LSIIR
BjoernLudwigPTB Oct 27, 2021
1da86d6
Merge branch 'prepare_major_release_2.0.0' into fix/#147_rewrite_inve…
BjoernLudwigPTB Oct 27, 2021
fd21dd0
Merge branch 'prepare_major_release_2.0.0' into fix/#147_rewrite_inve…
BjoernLudwigPTB Oct 28, 2021
5871194
Merge branch 'prepare_major_release_2.0.0' into fix/#147_rewrite_inve…
BjoernLudwigPTB Oct 28, 2021
b72004c
refactor(fit_filter): move __all__ to top according to PEP 8
BjoernLudwigPTB Oct 13, 2021
e54d928
refactor(fit_filter): always return something for uncertainties be it…
BjoernLudwigPTB Oct 28, 2021
15aa0cf
refactor(fit_filter): improve module docstring
BjoernLudwigPTB Oct 28, 2021
9ded437
refactor(fit_filter): improve some LSIIR related naming and clean code
BjoernLudwigPTB Oct 28, 2021
7c17f4b
refactor(LSIIR): remove some unneeded comments
BjoernLudwigPTB Oct 28, 2021
3e30f8a
refactor(LSIIR): remove one function not needed for better readability
BjoernLudwigPTB Oct 28, 2021
92cfb43
refactor(conftest): check for the actual value of the CIRCLECI enviro…
BjoernLudwigPTB Oct 29, 2021
327b2d1
refactor(test_invLSFIR_uncMC_with_wrong_len_weights): remove capsys.d…
BjoernLudwigPTB Oct 29, 2021
9e2b146
refactor(fit_filter): exchange actual type checking errors by TypeErrors
BjoernLudwigPTB Oct 29, 2021
494e542
refactor(fit_filter): rename a parameter of _validate_vector_and_corr…
BjoernLudwigPTB Oct 29, 2021
734b8d7
refactor(fit_filter): correct module docstring
BjoernLudwigPTB Oct 29, 2021
8a4a2cd
refactor(fit_filter): improve module imports
BjoernLudwigPTB Oct 29, 2021
cd81a1d
refactor(test_LSIIR): replace two assertions
BjoernLudwigPTB Oct 29, 2021
1b11b61
refactor(test_LSIIR): remove file encoding
BjoernLudwigPTB Oct 29, 2021
750cc3b
refactor(test_LSIIR): optimize black variable arrangement
BjoernLudwigPTB Oct 29, 2021
2b5c247
refactor(fit_filter): replace keyword by positional parameters in alm…
BjoernLudwigPTB Oct 29, 2021
4e4c4fa
refactor(fit_filter): unify the use of H and UH across the whole modu…
BjoernLudwigPTB Oct 29, 2021
9d65dc3
refactor(LSIIR): improve docstring
BjoernLudwigPTB Oct 29, 2021
5774e15
refactor(invLSFIR_uncMC): improve docstring
BjoernLudwigPTB Oct 29, 2021
9a1026d
refactor(fit_filter): remove one unneeded copying of freqs
BjoernLudwigPTB Oct 29, 2021
f214de2
refactor(fit_filter): correct type hints of _validate_and_return_weights
BjoernLudwigPTB Oct 29, 2021
efedcab
refactor(fit_filter): correct type hint _get_first_public_caller
BjoernLudwigPTB Oct 29, 2021
6b66ee6
refactor(fit_filter): correct filename checking in _get_first_public_…
BjoernLudwigPTB Oct 29, 2021
868a563
refactor(fit_filter): reuse _input_for_svd_was_provided and _number_o…
BjoernLudwigPTB Oct 29, 2021
fd4d3b8
refactor(fit_filter): replace hardcoded function name in error messag…
BjoernLudwigPTB Oct 29, 2021
493938e
refactor(_fit_filter_coeffs_via_least_squares): rename from _fit_fir_…
BjoernLudwigPTB Oct 29, 2021
6a54931
refactor(fit_filter): correct one variable name
BjoernLudwigPTB Oct 29, 2021
0f19578
refactor(fit_filter): reuse _no_uncertainties_were_provided
BjoernLudwigPTB Oct 29, 2021
3010ce1
refactor(test_compare_invLSFIR_unc_to_invLSFIR_uncMC): adapt bound to…
BjoernLudwigPTB Oct 29, 2021
acb9b3a
refactor(interpolate): remove encoding from module and improve docstring
BjoernLudwigPTB Oct 29, 2021
474ea6c
refactor(interpolate): move __all__ to top according to PEP 8
BjoernLudwigPTB Oct 29, 2021
f569c48
refactor(interpolate): correct docstring formatting and content
BjoernLudwigPTB Oct 29, 2021
23bb026
refactor(interpolation): remove file encoding from module
BjoernLudwigPTB Oct 29, 2021
cdac09d
refactor(interpolation): correct docstring indentation
BjoernLudwigPTB Oct 29, 2021
f046085
refactor(propagate_DWT): remove encoding from module and introduce si…
BjoernLudwigPTB Oct 29, 2021
1e27ca4
refactor(propagate_DWT): move __all__ to top according to PEP 8
BjoernLudwigPTB Oct 29, 2021
186f489
refactor(wave_rec): correct docstring and its indentation
BjoernLudwigPTB Oct 29, 2021
fe26aa6
refactor(PyDynamic.uncertainty.rst): correctly link the interpolate m…
BjoernLudwigPTB Oct 29, 2021
9779840
refactor(make_equidistant): correctly indent deprecation warning
BjoernLudwigPTB Oct 29, 2021
a6ea05d
Revert "refactor(fit_filter): correct filename checking in _get_first…
BjoernLudwigPTB Oct 29, 2021
1672831
refactor(fit_filter): adapt filename checking in _get_first_public_ca…
BjoernLudwigPTB Oct 29, 2021
0ea1885
refactor(interp1d_unc): correct docstring formatting of conditional r…
BjoernLudwigPTB Oct 29, 2021
ab30b4b
docs: fix some formatting issues resulting in strange looking or misl…
BjoernLudwigPTB Oct 29, 2021
6a1ba41
refactor(model_estimation): remove file encoding and introduce first …
BjoernLudwigPTB Oct 29, 2021
3a457ba
refactor(fit_filter): remove those old (inv)LSFIR(unc) functions befo…
BjoernLudwigPTB Oct 29, 2021
2d07f53
refactor(deconvolution): remove file encoding and all from module fit…
BjoernLudwigPTB Oct 29, 2021
f0674f0
refactor(fit_filter): rename invLSFIR_uncMC to LSFIR and adapt tests …
BjoernLudwigPTB Oct 29, 2021
b32db9d
refactor(deconv_FIR): blacken example
BjoernLudwigPTB Oct 29, 2021
d4a1a78
refactor(conftest.py): improve check for singularity
BjoernLudwigPTB Nov 1, 2021
673b79f
refactor(test_fir_filter_MC_comparison): convert into hypothesis test
BjoernLudwigPTB Nov 1, 2021
ddf51b4
Revert "refactor(test_fir_filter_MC_comparison): convert into hypothe…
BjoernLudwigPTB Nov 2, 2021
70ff62d
refactor(fit_filter): introduce legacy calls for all those former fun…
BjoernLudwigPTB Nov 2, 2021
7f36f9a
refactor(test_LSFIR): introduce tests for those legacy calls
BjoernLudwigPTB Nov 2, 2021
0b860b2
refactor(test_compare_invLSFIR_unc_LSFIR): adjust bounds
BjoernLudwigPTB Nov 2, 2021
8aedda2
refactor(test_compare_invLSFIR_unc_LSFIR): reduce comparison of invLS…
BjoernLudwigPTB Nov 2, 2021
76db0d7
Merge pull request #252 from PTB-M4D/try_to_improve_fir_filter_and_mc…
BjoernLudwigPTB Nov 3, 2021
900e10a
refactor(LSFIR): improve docstring
BjoernLudwigPTB Nov 3, 2021
2d0dc79
refactor(LSFIR): further improve docstring
BjoernLudwigPTB Nov 3, 2021
e87ba81
refactor(conf.py): delete one annoying todo
BjoernLudwigPTB Nov 3, 2021
ed543f9
refactor(test_compare_LSFIR_with_zero_to_None_uncertainties_and_mc_fo…
BjoernLudwigPTB Nov 3, 2021
fe2d5bd
refactor(fit_filter): reorder __all__ alphabetically
BjoernLudwigPTB Nov 3, 2021
d3d28cb
refactor(fit_filter): move up LSIIR wrappers and shorten their docstr…
BjoernLudwigPTB Nov 3, 2021
6783d6f
refactor(fit_filter): shorten LSFIR wrappers' docstrings
BjoernLudwigPTB Nov 3, 2021
1288104
refactor(test_LSFIR.py): simplify implementation of weight generation
BjoernLudwigPTB Nov 3, 2021
0c9c133
refactor(test_LSFIR): introduce those _assemble_… functions into fixt…
BjoernLudwigPTB Nov 3, 2021
fe8c5e5
refactor(fit_filter): remove one unused import of os.path
BjoernLudwigPTB Nov 3, 2021
0f5021f
Merge branch 'fix/#147_rewrite_inverse_methods_of_model_estimation' i…
BjoernLudwigPTB Nov 3, 2021
d36f92a
refactor(test_compare_invLSFIR_unc_to_invLSFIR_uncMC): improve bounds
BjoernLudwigPTB Nov 3, 2021
9a30c05
Merge branch 'fix/#147_rewrite_inverse_methods_of_model_estimation' i…
BjoernLudwigPTB Nov 3, 2021
1a857fe
refactor(test_compare_LSFIR_with_svd_and_with_mc): remove uncertainty…
BjoernLudwigPTB Nov 4, 2021
7239b93
refactor(test_compare_LSFIR_with_svd_and_with_mc): delete unused vari…
BjoernLudwigPTB Nov 4, 2021
bcc4605
refactor(test_compare_LSFIR_with_svd_and_with_mc): adjust bounds
BjoernLudwigPTB Nov 4, 2021
8aca955
feat: Weighted least-squares IIR or FIR filter fit to freq. resp. or …
BjoernLudwigPTB Nov 4, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions PyDynamic/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,8 @@

__all__ = [
"invLSFIR",
"invLSIIR",
"invLSFIR_unc",
"invLSFIR_uncMC",
"invLSIIR_unc",
"LSFIR",
"LSIIR",
"fit_som",
Expand Down
34 changes: 20 additions & 14 deletions PyDynamic/misc/filterstuff.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
to the unit circle
* :func:`kaiser_lowpass`: Design of a FIR lowpass filter using the window technique
with a Kaiser window.
* :func:`isstable`: Determine whether a given IIR filter is stable
* :func:`isstable`: Determine whether an IIR filter with certain coefficients is stable
* :func:`savitzky_golay`: Smooth (and optionally differentiate) data with a
Savitzky-Golay filter

Expand All @@ -33,7 +33,7 @@


def db(vals):
"""Calculation of decibel values :math:`20\log_{10}(x)` for a vector of values"""
r"""Calculation of decibel values :math:`20\log_{10}(x)` for a vector of values"""
return 20 * np.log10(np.abs(vals))


Expand Down Expand Up @@ -146,29 +146,35 @@ def kaiser_lowpass(L, fcut, Fs, beta=8.0):


def isstable(b, a, ftype="digital"):
"""Determine whether `IIR filter (b,a)` is stable
"""Determine whether an IIR filter with certain coefficients is stable

Determine whether `IIR filter (b,a)` is stable by checking roots of the
polynomial ´a´.
Determine whether IIR filter with coefficients `b` and `a` is stable by checking
the roots of the polynomial `a`.

Parameters
----------
b: ndarray
filter numerator coefficients
a: ndarray
filter denominator coefficients
ftype: string
type of filter (`digital` or `analog`)
b : ndarray
Filter numerator coefficients. These are only part of the input
parameters for compatibility reasons (especially with MATLAB code). During the
computation they are actually not used.
a : ndarray
Filter denominator coefficients.
ftype : string, optional
Filter type. 'digital' if in discrete-time (default) and 'analog' if in
continuous-time.

Returns
-------
stable: bool
whether filter is stable or not

stable : bool
Whether filter is stable or not.
"""
v = np.roots(a)
# Check if all of the roots of the polynomial made from the filter coefficients...
if ftype == "digital":
# ... lie inside the unit circle in discrete time.
return not np.any(np.abs(v) > 1.0)
elif ftype == "analog":
# ... are non-negative in continuous time.
return not np.any(np.real(v) < 0)


Expand Down
2 changes: 0 additions & 2 deletions PyDynamic/model_estimation/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,7 @@
"LSFIR",
"LSIIR",
"invLSFIR",
"invLSIIR",
"invLSFIR_unc",
"invLSFIR_uncMC",
"invLSIIR_unc",
"fit_som",
]
Loading