uavcan: add node status logging to uORB #23890
Open
+158
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dakejahl
force-pushed
the
pr-uavcan_node_status_logging
branch
2 times, most recently
from
5f7c105
to
d9d936e
Compare
|
@vertiq-jordan let me know what you think |
Looks good on my end! Here's a couple of quick captures of one of our nodes going through the different health cases: Here's a sanity check that everyone is reporting the correct Node ID/they're being logged: I'll get on the Extended ESC Status PR shortly, thank you! |
|
I do quite like this, we just need to make it fit. |
Co-authored-by: Jordan Leiber <[email protected]>
dakejahl
force-pushed
the
pr-uavcan_node_status_logging
branch
from
d9d936e
to
339824f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial implementation taken from #23882 but reimplemented using the existing interface. This adds ~700B to flash for the extra data in
NodeStatusbut I think it's worth it