Added various features to flash analysis #24072
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…w, summary in comment output, newer bloaty version, only add comment if change is large enough, ...)
mrpollo
reviewed
Dec 4, 2024
| run: make ${{ matrix.target }} | ||
| # Use special flash-analysis target if present. Otherwise fall back to the default target. | ||
| run: | | ||
| if make list_config_targets | grep ${{ matrix.target }}_flash-analysis; then |
There was a problem hiding this comment.
Why do we need to check this here? Can we hardcode the target name?
| if make list_config_targets | grep ${{ matrix.target }}_flash-analysis; then | ||
| cp ./build/${{ matrix.target }}_flash-analysis/${{ matrix.target }}_flash-analysis.elf ./with-change.elf | ||
| else | ||
| cp ./build/${{ matrix.target }}_default/${{ matrix.target }}_default.elf ./with-change.elf |
There was a problem hiding this comment.
Can you find the elf file by a wildcard search? cp ./build/**/*.elf ./with-change.elf?
|
|
||
| post_pr_comment: | ||
| name: Publish Results | ||
| runs-on: [runs-on,runner=1cpu-linux-x64,image=ubuntu24-full-x64,"run-id=${{ github.run_id }}",spot=false] | ||
| needs: [analyze_flash] | ||
| env: | ||
| V5X-SUMMARY-MAP: ${{ needs.analyze_flash.outputs.px4_fmu-v5x-bloaty-summary-map }} |
There was a problem hiding this comment.
I disagree with the use of env in principle, but I see how it's way cleaner than the uber-long string. I would go one step further and do the fromJSON casting here so you avoid it everywhere else below.
V5X-SUMMARY-MAP: ${{ fromJSON(fromJSON(needs.analyze_flash.outputs.px4_fmu-v5x-bloaty-summary-map).vm-absolute) }}
V5X-SUMMARY-PERC: ${{ fromJSON(fromJSON(needs.analyze_flash.outputs.px4_fmu-v5x-bloaty-summary-map).vm-percentage) }}
V6X-SUMMARY-MAP: ${{ fromJSON(fromJSON(needs.analyze_flash.outputs.px4_fmu-v6x-bloaty-summary-map).vm-absolute) }}
V6X-SUMMARY-PERC: ${{ fromJSON(fromJSON(needs.analyze_flash.outputs.px4_fmu-v6x-bloaty-summary-map).vm-percentage) }}
| @@ -92,25 +129,32 @@ jobs: | |||
| echo "timestamp=$(date +'%Y-%m-%dT%H:%M:%S')" >> $GITHUB_OUTPUT | |||
|
|
|||
| - name: Create or update comment | |||
| # This can't be moved to the job-level conditions, as GH actions don't allow a job-level if condition to access the env. | |||
There was a problem hiding this comment.
An alternative to using env is to introduce a new step that sets the outputs, but it should be fine as is right now.
| uses: peter-evans/create-or-update-comment@v4 | ||
| with: | ||
| comment-id: ${{ steps.fc.outputs.comment-id }} | ||
| issue-number: ${{ github.event.pull_request.number }} | ||
| body: | | ||
| ## FLASH Analysis | ||
| ## 🔎 FLASH Analysis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solved Problem
There has been feedback regarding the FLASH analysis tool. This PR adds several of the requested features.
Solution
Test coverage