Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add webpack5 polyfill #30

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

smeng9
Copy link

@smeng9 smeng9 commented Jan 18, 2023

Currently when we use the @paciolan/remote-component in create-react-app 5.0.1 (webpack 5), it will throw errors "webpack < 5 used to include polyfills for node.js core modules..." as webpack 5 no longer polyfills http and https node module.

We need to include polyfill dependencies by ourselves and use a browser field.

@smeng9
Copy link
Author

smeng9 commented Jan 18, 2023

Closes #27

@smeng9
Copy link
Author

smeng9 commented Jan 18, 2023

Linked issue: Paciolan/remote-component#52

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant