added empty check objects for request params

PacktDev · Jul 22, 2019 · 760fdde · 760fdde
1 parent 052815f
commit 760fdde
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/clients/clientFactory.ts b/src/clients/clientFactory.ts
@@ -30,7 +30,7 @@ export default abstract class ClientFactory {
     this.authTypes = config.authTypes;
     this.basePath = config.basePath;
     this.pathParams = config.pathParams;
-    this.queryParams = config.pathParams;
+    this.queryParams = config.queryParams;
     this.headerParams = config.headerParams;
     this.formParams = config.formParams;
     this.timeout = config.timeout || 60000;

diff --git a/src/clients/superAgentClient.ts b/src/clients/superAgentClient.ts
@@ -49,11 +49,11 @@ export default class SuperAgentClient extends ClientFactory {
       let request = Superagent(httpMethod, url);
       request = this.applyAuthToRequest(request, this.authTypes);
 
-      if (this.queryParams) {
+      if (this.queryParams && Object.keys(this.queryParams).length) {
         request.query(this.normalizeParams(this.queryParams));
       }
 
-      if (this.headerParams) {
+      if (this.headerParams && Object.keys(this.headerParams).length) {
         request.set(this.normalizeParams(this.headerParams));
       }