Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Build][Update] Update the project's build process to pyproject. #1221

Merged
merged 11 commits into from
Apr 10, 2024
Merged

[Build][Update] Update the project's build process to pyproject. #1221

merged 11 commits into from
Apr 10, 2024

Conversation

Zheng-Bicheng
Copy link
Collaborator

@Zheng-Bicheng Zheng-Bicheng commented Apr 9, 2024 •
edited
Loading

  • 移动third目录到third_party
  • 迁移项目构建方式到pyproject.toml

@Zheng-Bicheng
Copy link
Collaborator Author

大佬们，我也是第一次做这种迁移操作，麻烦大家一起看看这个PR有啥还需要完善的

GreatV
GreatV reviewed Apr 9, 2024
View reviewed changes
.github/workflows/build.yml Outdated Show resolved Hide resolved
jzhang533
jzhang533 reviewed Apr 9, 2024
View reviewed changes
setup.py Outdated Show resolved Hide resolved
jzhang533
jzhang533 reviewed Apr 9, 2024
View reviewed changes
pyproject.toml Outdated Show resolved Hide resolved
@GreatV
Copy link
Collaborator

GreatV commented Apr 9, 2024

这个可以生成多个版本的python wheel包吗，像这个 https://cibuildwheel.pypa.io/en/stable/ 一样。
image

@Zheng-Bicheng
Copy link
Collaborator Author

这个可以生成多个版本的python wheel包吗，像这个 https://cibuildwheel.pypa.io/en/stable/ 一样。 image

这个后面会尝试用docker来做

jzhang533
jzhang533 approved these changes Apr 9, 2024
View reviewed changes
Copy link
Collaborator

@jzhang533 jzhang533 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Zheng-Bicheng Zheng-Bicheng merged commit ac04bca into PaddlePaddle:develop Apr 10, 2024
2 of 3 checks passed
@Zheng-Bicheng Zheng-Bicheng mentioned this pull request Apr 10, 2024
Closed
@Zheng-Bicheng Zheng-Bicheng deleted the pyproject branch April 10, 2024 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GreatV GreatV GreatV approved these changes

@jzhang533 jzhang533 jzhang533 approved these changes

@Jiang-Jia-Jun Jiang-Jia-Jun Awaiting requested review from Jiang-Jia-Jun

@Aurelius84 Aurelius84 Awaiting requested review from Aurelius84

Assignees
No one assigned
Labels
Build contributor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Zheng-Bicheng @GreatV @jzhang533