Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added vartype='member' to BgpPolicyRule:action_community_argument #233

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

steve-krause
Copy link
Contributor

added vartype='member' to the BgpPolicyRule class parameter 'action_community_argument' in network.py

Description

I changed the vartype to "member" in order to correctly parse a template with the BgpPolicyRule action_community set to append and an argument of 65100:1

Motivation and Context

I was unable to make any changes to the BGP configuration of the virtual-router because our template had an community_action set to append with an argument of 65100:1. Whenever I tried to make a change to certain sections of config under the virtual-router I would receive an error.

How Has This Been Tested?

I am now able to successfully parse and change the virtual-router section of the templates in question without errors

Screenshots (if appropriate)

Types of changes

changes the way the BgpPolicyRule community_action_argument is deployed on the device

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes if appropriate.
  • All new and existing tests passed.

@steve-krause
Copy link
Contributor Author

I am not sure why this pull request hasn't been looked at and approved. We have made the change and used it successfully a number of times in our environment. Please let me know if I need to take action to move this forward. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant