-
-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docs for i18n in paper #194
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also needs at least a short code example
Ok, added an example using |
As someone who hasn't used translatable components before, I would want an example of how to send these / create these components. Also, an explanation to what a translation key and/or what the translation files look like. |
Good call. We can talk about the As for an example of a resource bundle file... that is just one implementation. You can create translations from any format you want, its not closed off. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, the only thing I would say is that it probably needs an example of using a translatable component
6de104f
to
3637a46
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
part of #190