chore(notebooks): remove deprecated option nb-1131 (#388)

Paperspace · May 31, 2022 · 16fad0c · 16fad0c
1 parent f3d1b32
commit 16fad0c
Show file tree

Hide file tree

Showing 6 changed files with 0 additions and 15 deletions.
diff --git a/gradient/api_sdk/clients/notebook_client.py b/gradient/api_sdk/clients/notebook_client.py
@@ -16,7 +16,6 @@ def create(
             registry_username=None,
             registry_password=None,
             command=None,
-            container_user=None,
             shutdown_timeout=None,
             is_preemptible=None,
             is_public=None,
@@ -38,7 +37,6 @@ def create(
         :param str registry_username:
         :param str registry_password:
         :param str command:
-        :param str container_user:
         :param int shutdown_timeout:
         :param bool is_preemptible:
         :param bool is_public:
@@ -62,7 +60,6 @@ def create(
             registry_username=registry_username,
             registry_password=registry_password,
             command=command,
-            container_user=container_user,
             shutdown_timeout=shutdown_timeout,
             is_preemptible=is_preemptible,
             machine_type=machine_type,

diff --git a/gradient/api_sdk/models/notebook.py b/gradient/api_sdk/models/notebook.py
@@ -20,7 +20,6 @@ class Notebook(object):
     registry_password = attr.ib(type=str, default=None)
     command = attr.ib(type=str, default=None)
     default_entrypoint = attr.ib(type=str, default=None)
-    container_user = attr.ib(type=str, default=None)
     shutdown_timeout = attr.ib(type=int, default=None)
     is_preemptible = attr.ib(type=bool, default=None)
     project_id = attr.ib(type=str, default=None)

diff --git a/gradient/api_sdk/serializers/notebook.py b/gradient/api_sdk/serializers/notebook.py
@@ -21,7 +21,6 @@ class NotebookSchema(BaseSchema):
     registry_password = marshmallow.fields.Str(load_from="registryPassword", dump_to="registryPassword")
     command = marshmallow.fields.Str(load_from="command", dump_to="command")
     default_entrypoint = marshmallow.fields.Str(load_from="defaultEntrypoint", dump_to="defaultEntrypoint")
-    container_user = marshmallow.fields.Str(load_from="containerUser", dump_to="containerUser")
     shutdown_timeout = marshmallow.fields.Int(load_from="shutdownTimeout", dump_to="shutdownTimeout")
     is_preemptible = marshmallow.fields.Bool(load_from="isPreemptible", dump_to="isPreemptible")
     is_public = marshmallow.fields.Bool(load_from="isPublic", dump_to="isPublic")

diff --git a/gradient/cli/notebooks.py b/gradient/cli/notebooks.py
@@ -84,13 +84,6 @@ def notebook_metrics():
     help="Command (executed as `/bin/sh -c 'YOUR COMMAND'`)",
     cls=common.GradientOption,
 )
-@click.option(
-    "--containerUser",
-    "container_user",
-    type=str,
-    help="Container user",
-    cls=common.GradientOption,
-)
 @click.option(
     "--shutdownTimeout",
     "shutdown_timeout",

diff --git a/tests/config_files/notebooks_create.yaml b/tests/config_files/notebooks_create.yaml
@@ -3,7 +3,6 @@ clusterId: 321
 projectId: pr1234
 container: "jupyter/notebook"
 command: some_entrypoint
-containerUser: some_container_user
 isPreemptible: true
 name: some_notebook_name
 registryPassword: some_password

diff --git a/tests/functional/test_notebooks.py b/tests/functional/test_notebooks.py
@@ -97,7 +97,6 @@ class TestNotebooksCreate(object):
         "--registryUsername", "some_username",
         "--registryPassword", "some_password",
         "--command", "some_entrypoint",
-        "--containerUser", "some_container_user",
         "--shutdownTimeout", "8",
         "--environment", '{"key":"val"}',
         "--isPreemptible",
@@ -112,7 +111,6 @@ class TestNotebooksCreate(object):
         "registryUsername": "some_username",
         "registryPassword": "some_password",
         "command": "c29tZV9lbnRyeXBvaW50",
-        "containerUser": "some_container_user",
         "environment": {"key": "val"},
         "shutdownTimeout": 8,
         "isPreemptible": True,