Skip to content

Commit

Permalink
fix(notebooks): remove --name from gradient notebooks start command (
Browse files Browse the repository at this point in the history
…#362)

Tested against psdev, created a notebook in the UI, stopped it, ran
```bash
python3 -m gradient notebooks start \
  --clusterId <cluster ID> \
  --machineType psdev-worker
  --notebookId <notebook ID>
```
and saw the notebook successfully restart. Verified that `--name` was no
longer a valid CLI param for the command with
```bash
python3 -m gradient notebooks start --help
```
  • Loading branch information
cwetherill-ps authored Sep 3, 2021
1 parent 3a56306 commit c165974
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 10 deletions.
2 changes: 0 additions & 2 deletions gradient/api_sdk/clients/notebook_client.py
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,6 @@ def start(
id,
machine_type,
cluster_id=None,
name=None,
shutdown_timeout=None,
is_preemptible=None,
tags=None,
Expand All @@ -108,7 +107,6 @@ def start(
notebook_id=id,
machine_type=machine_type,
cluster_id=cluster_id,
notebook_name=name,
shutdown_timeout=shutdown_timeout,
is_preemptible=is_preemptible,
)
Expand Down
1 change: 0 additions & 1 deletion gradient/api_sdk/models/notebook.py
Original file line number Diff line number Diff line change
Expand Up @@ -72,5 +72,4 @@ class NotebookStart(object):
cluster_id = attr.ib(type=str, default=None)
shutdown_timeout = attr.ib(type=int, default=None)
is_preemptible = attr.ib(type=bool, default=None)
notebook_name = attr.ib(type=str, default=None)

7 changes: 0 additions & 7 deletions gradient/cli/notebooks.py
Original file line number Diff line number Diff line change
Expand Up @@ -190,13 +190,6 @@ def create_notebook(api_key, options_file, **notebook):
help="Cluster ID",
cls=common.GradientOption,
)
@click.option(
"--name",
"name",
type=str,
help="Notebook name",
cls=common.GradientOption,
)
@click.option(
"--shutdownTimeout",
"shutdown_timeout",
Expand Down

0 comments on commit c165974

Please sign in to comment.