-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Organized Paradigm Library (Correctly this time, hopefully) #19
base: master
Are you sure you want to change the base?
Conversation
…les and renamed module folders with .pretty to follow the KiCad/kicad-footprints structre
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change connectors,pretty to connectors.pretty and you should be good! the .lib files look correct
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few minor fixes:
-Capacitor.pretty -> Capacitors.pretty
-Connectors,pretty -> Deleted
-Optocoupler.pretty -> Optocouplers.pretty (generally, pluralize all component names)
-Resistors,pretty -> Resistors.pretty (and deleted sub-folder "SMD")
-Remove .DS_Store files (can put these in .gitignore)
-Diods.lib -> Diodes.lib
Also, please check with Ed about the way you're doing this merge. It looks like you forked our repo, made changes, and are now attempting to merge back in. Normally, you should just create a branch within our repo for changes like this.
Going to withhold my review until James and Merkl feel their changes are complete because repeating the same 90% of aforementioned stuff is unhelpful and makes it hard to identify the 10% of stuff that hasn't already been said |
…lers.pretty, Resistors,pretty -> Resistors.pretty, Diods.lib -> Diodes.lib and removed *.DS_Store files
@jmassucco17 this PR is done on a branch making it much easier to review and checkout. The "squash and merge" button can be found on this PR below and should be used when this is finally ready to compress all the changes into a single commit. |
Restructured ParadigmLibrary components into their respective .lib files and renamed module folders with .pretty to follow the KiCad/kicad-footprints structure