Some cleaning, improved logging output and async problem solved #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've encountered the same problems in my installation with 8 sensors. The proposed patch works for me, please consider accepting it. |
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* Fix bug in uuidTab generation - From tabSensors entries, use characters 0..5 and 12..17 instead of 0..6 and 13..17 * Add time and horizontal line * Complete overhaul of sensor handling - Use async.waterfall instead of async.serial for proper error handling - Tidy up code, add more comments to improve readability - Move readout and upload code to seperate function for readability - Use structured sensors array to keep sensorSerial/uuid relation - Avoid global variables where possible - Catch any exceptions thrown by node-flower-power code - Readout sensors in same order they where discovered * Add battery level reading * Add FHEM inform mechanism * When reporting to FHEM, use XHR=1 and report result to console * Fix callback sequence, disconnect must be last * Reorganize code to add more stability - Move FHEM reporting to function called by main waterfall * Add workaround to close leftover connections (saves battery power) --------- Co-authored-by: Andy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following things are done: