Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport to 6.1] Native message attributes are not loaded when using LocalStack #2298

Merged

Conversation

mauroservienti
Copy link
Member

@mauroservienti mauroservienti commented Sep 26, 2023

Symptoms

When using LocalStack, the transport doesn't load native message attributes in native integration scenarios.

Who's affected

You're affected if you're using LocalStack and doing native integration.

Root cause

The transport uses the undocumented (but supported) * syntax to load all attributes instead of the supported .* or All


This PR fixes a bug that prevents native integration from working when using localstack, a local AWS cloud stack implementation.

More information in #2288

…en using localstack instead of real AWS cloud (#2289)

* Update requested MessageAttributeNames to match the wildcard in the AWS SQS docs

* Adjust tests to the new wildcard format

* Consistently use All

---------

Co-authored-by: Maddie Hermann <[email protected]>
Co-authored-by: danielmarbach <[email protected]>
@mauroservienti mauroservienti marked this pull request as ready for review October 9, 2023 13:51
@mauroservienti mauroservienti added this to the 6.1.2 milestone Oct 9, 2023
@mauroservienti mauroservienti merged commit 1d031a3 into release-6.1 Oct 11, 2023
@mauroservienti mauroservienti deleted the fix-localstack-native-integration-on-6-1 branch October 11, 2023 12:12
@mauroservienti mauroservienti changed the title [Backport to 6.1] Use wildcard format as documented by AWS to fix native integration when using localstack instead of real AWS cloud [Backport to 6.1] Use wildcard format as documented by AWS to fix native integration when using LocalStack instead of real AWS cloud Oct 11, 2023
@mauroservienti mauroservienti changed the title [Backport to 6.1] Use wildcard format as documented by AWS to fix native integration when using LocalStack instead of real AWS cloud [Backport to 6.1] Native message attributes are not loaded when using LocalStack Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants