Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add message extraction tests #2334

Merged
merged 5 commits into from
Nov 7, 2023
Merged

Add message extraction tests #2334

merged 5 commits into from
Nov 7, 2023

Conversation

SzymonPobiega
Copy link
Member

Moves the message extraction tests logic from #2331 to master

@SzymonPobiega SzymonPobiega self-assigned this Nov 3, 2023
mikeminutillo
mikeminutillo approved these changes Nov 7, 2023
View reviewed changes
Copy link
Member

@mikeminutillo mikeminutillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. We may want to wait for #2336 and #2338 before merging

@mauroservienti mauroservienti merged commit a216629 into master Nov 7, 2023
2 checks passed
@mauroservienti mauroservienti deleted the add-message-extraction-tests branch November 7, 2023 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mauroservienti mauroservienti mauroservienti approved these changes

@mikeminutillo mikeminutillo mikeminutillo approved these changes

Assignees

@SzymonPobiega SzymonPobiega

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SzymonPobiega @mikeminutillo @mauroservienti