Process raw messages #2341
Merged
Process raw messages #2341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Unwrapped messages are poisonous message if the NServiceBus.AmazonSQS.Headers cannot be deserialized * Delete commented code
With full native integration support that's not a poison message
| @@ -104,6 +142,7 @@ static IEnumerable<TestCaseData> GenerateTestCases(bool passMessageIdInMessageAt | |||
| var senderTransportMessage = new TransportMessageBuilder() | |||
| .If(passMessageIdInNsbHeaders, t => t | |||
| .WithHeader(Headers.MessageId, nsbMessageIdPassedThroughHeaders)) | |||
| .WithHeader(Headers.EnclosedMessageTypes, "Enclosed message type") | |||
There was a problem hiding this comment.
NOTE: Message-Id is one of the headers that is used to decide whether this is a valid non-native message. If it's not included then we need the other header, which is enclosed message type
mauroservienti
approved these changes
Nov 10, 2023
SzymonPobiega
added a commit
that referenced
this pull request
Nov 10, 2023
This was referenced Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #2319
TODO