Change Passes to only always, never or average crit chance #8270
+30
−18
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly a background change for a minor performance boost and to change what is displayed on the calcs page
This is mostly for something like plume of pursuit, which has an 80% less damage multiplier for non crits, but for the hits you care about it will always be a crit, this also will show inquisitors inevitable judgement ignore res instead of pen if your guaranteed to crit.
I have been sitting on this for a while and couldnt find any issues on any builds I tested, but it likely needs to be tested on more builds incase there is an issue. This also sets the crit
skillCond
as late as it can to prevent other issues, so that it doesnt impact any calculations, and only does it if its certain it will apply (100% chance), this could be changed to show in the average case (eg if crit chance is >= 50%) as its after all relevant calculations are done, but decided to be conservative