Fix elemental overload not reducing ailment chance to 0 #8325
+12
−15
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8137
Description of the problem being solved:
Currently it seems the "Ailments never count as being from Critical Strikes" mod line found on the Elemental Overload keystone is implemented by simply never running the crit calculation pass when calculating ailments. This causes the ailment chance to still show up in the breakdown and cause issues with the Perfect Agony keystone which makes ailments only apply from crits.
Marking this as draft for now as this could really use a review by someone more familiar with ailment calculations.
Link to a build that showcases this PR: