Fixes minor issues with only crit ailments, and the display value for chance to apply and for dot multi #8336
+10
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems like there's some problems downloading Lua for the automated tests? |
luajit bin is no longer available. #8199 |
|
So what needs to change in this PR and/or the pipeline? |
This isn't an issue with the pr. The pipeline needs to be updated with a different source for the binary. I proposed to use a docker container in my pr. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8334.
This fixes the displayed chance to apply bleed/ignite if its only from crits, this likely needs to be fixed in a better way, as well as the displayed dot multi values, noting that it was using the correct dot multi values for the actual damage calculation, and just displaying a different "average value" in breakdowns.
This also makes it so that if all instances are from crits then it wont scale up the ailment crit chance, this might be the wrong way to do it, and it might be best to have it apply 100% chance (as all instances are always crits), but I havnt looked through the calcs properly, and it would atleast require us to fix the chance to apply calcs