Add option to strip advanced copy paste info out #8344
+52
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes 2 issues, it fixes the issue that items are still added to the display and parsed even if you dont want them to, which can cause crashes, and this allows you to strip the advanced info out so you dont need to go recopy the item.
The UI could use work (better wording/spacing/sizing of elements), and it might be a good idea to move the popup code out of Items Tab
inputEventsto its own class function.I also want to add an option in future that converts an advanced copy paste to a pseudo crafted item, where you can easily adjust the mods or the roll ranges, but that is out of scope for this.