[stripe] error not detected in some cases.

Payum · Sep 15, 2016 · 1ed05ec · 1ed05ec
1 parent 764d427
commit 1ed05ec
Show file tree

Hide file tree

Showing 2 changed files with 29 additions and 3 deletions.
diff --git a/Action/StatusAction.php b/Action/StatusAction.php
@@ -20,6 +20,12 @@ public function execute($request)
 
         $model = ArrayObject::ensureArrayObject($request->getModel());
 
+        if ($model['error']) {
+            $request->markFailed();
+
+            return;
+        }
+
         if (false == $model['status'] && false == $model['card']) {
             $request->markNew();
 

diff --git a/Tests/Action/StatusActionTest.php b/Tests/Action/StatusActionTest.php
@@ -8,9 +8,9 @@
 
 class StatusActionTest extends GenericActionTest
 {
-    protected $requestClass = 'Payum\Core\Request\GetHumanStatus';
+    protected $requestClass = GetHumanStatus::class;
 
-    protected $actionClass = 'Payum\Stripe\Action\StatusAction';
+    protected $actionClass = StatusAction::class;
 
     /**
      * @test
@@ -19,13 +19,33 @@ public function shouldMarkNewIfDetailsEmpty()
     {
         $action = new StatusAction();
 
-        $model = array();
+        $model = [];
 
         $action->execute($status = new GetHumanStatus($model));
 
         $this->assertTrue($status->isNew());
     }
 
+    /**
+     * @test
+     */
+    public function shouldMarkFailedIfDetailsHasErrorSet()
+    {
+        $action = new StatusAction();
+
+        $model = [
+            'error' => [
+                'type' => 'invalid_request_error',
+                'message' => 'Amount must be at least 50 cents',
+                'param' => 'amount',
+            ],
+        ];
+
+        $action->execute($status = new GetHumanStatus($model));
+
+        $this->assertTrue($status->isFailed());
+    }
+
     /**
      * @test
      */