fix: recycling and re-rendering issues with Masonry #360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkartalis
changed the title
1 task
gkartalis
commented
Aug 7, 2023
| // https://github.com/Shopify/flash-list/blob/2d31530ed447a314ec5429754c7ce88dad8fd087/src/FlashList.tsx#L829 | ||
| // We are not accessing the right element or view of the Flashlist (recyclerlistview). So we need to give | ||
| // this ref the access to it | ||
| ;(recyclerRef as any)(value?.recyclerlistview_unsafe) |
There was a problem hiding this comment.
this was not working properly before but like this it fixes the rendering issue! 🔥
There was a problem hiding this comment.
this and the recyclerRef + useEffect recyclerRef additions
|
@andreialecu let me know if you have any suggestions on how to proceed! Would love to see this merged because it solves many issues for us at Artsy! Turns out we don't explicitly need the shopify PR to get merged for this to work so they can be merged independently! 🎉 |
|
Alright. Going to merge this now. |
|
Released as 6.2.1 |
This was referenced Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When adding the lines for calling loadMore onEndReached of MasonryFlashlist we get this weird behavior in the example where the list flashes and returns to the top.
This PR fixes that but it requires exporting
recyclerlistviewUnsafefrom MasonryFlashListRef.This is happening due to us relying on the recyclerlistviewUnsafe while it not existsing on the MasonryFlashListRef interface.
Opened a PR in flash-list about that in order to solve the re-rendering issues.
and we need to merge this PR after the related flashlist pr gets merged and we bump the version here.turns out we don't need the other PR! Realised it after cleaning up the patch!I have patched the shopify library on this PR just to make sure that this solution works and will clean everything up before merging this.Follow ups:
merge flashlist related pr before merging this one- actually I think we can merge this as it is since it has the@ts-expect-errorabove the actualrecyclerlistview_unsafeline that protects it from crashing but at the same time might not work without patching the library / using a fork to make it actually work if shopify doesn't review / reject the PR.before.mp4
after.mp4