Improvements for autocompletion and goto #421
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the buffer position on the class name followed by a scope
resolution operator "::" getFullWordFromBufferPosition would select the
whole expression; but a later goto would then only look at the member
part and wrongfully try andgo to that member instead of the class
definition:
MyClass::class
^-- Buffer position here
* getFullWordFromBufferPosition returns "MyClass::class"
* goto tries to go to member "class" of class MyClass and fails
Adding the colon to forwardRegex will return only the class name instead
if buffer position is before the scope resolution operator but not if
after:
MyClass::class
^-- getFullWordFromBufferPosition now returns "MyClass"
MyClass::class
^-- but here still returns "MyClass::class"
This will sort suggestions containing exact matches of the search prefix first providing a better quality of suggestions
getAllVariablesInFunction returns every variable used in a function so far which willl then be used for autocompletion suggestions. But with variables used mulitple times in the function they will appear as duplicates in the suggestions. To fix this this now returns a list of unique variable names.
Changes made to the language-php syntax package broke the detection of opening and closing code blocks resulting in isInFunction always returning false
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some improvements/fixes:
::, e.g.MyClass::classto go toMyClassfixes #368
fixes #366