Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import and Write Smart Contracts Necessary to Integrate Maker Allocator SubDAOs to Sommelier Vaults and other ERC4626 Vaults #146

Closed

Conversation

0xEinCodes
Copy link
Contributor

Core changes:

This PR encompasses the integration of MakerDAO / Allocator SubDAOs and Conduits into Sommelier cellars via the use of Conduits from MakerDAO && SparkProtocol, and possibly an modified version of the ArrangerConduit.sol from MakerDAO.

Initially the design of this adaptor encompassed writing a custom ERC4626Conduit.sol file, that is now commented out into ERC4626Conduit.nc (it is unfinished). ArrangerConduit.sol was seen as a already made smart contract that integrated well into Maker's "EndGame" Permissioned setup / architecture.

The only parts of the ArrangerConduit.sol that may need customization are including actual external calls into destination contracts to actually draw and return funds back to the buffer for a respective allocator.

Currently, this PR is in the discussion and design phase.

TODO

  • Review MakerDAO EndGame content (videos, docs, forum posts)
  • Review conduit codebases (MakerDAO and Spark repos)
  • Discuss the next steps on the preferred design for an erc4626 conduit for MakerDAO ecosystem
  • Implement
  • Test
  • Peer Review
  • Audit

References

  1. Lucas Manuel EndGame Presentation
  2. Phoenix Lab CEO Spark Intro
  3. Forum Post - Phoenix Lab Intro
  4. Spark Protocol
  5. MakerDAO IAllocator Conduit Github and MakerDAO Arranger Conduit Github
  6. Spark Conduit Github

@0xEinCodes 0xEinCodes self-assigned this Oct 10, 2023
@0xEinCodes 0xEinCodes closed this Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant