feat:multichain contract calls #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EricBolten
reviewed
Dec 15, 2023
src/cork.rs
Outdated
| } | ||
| let id = id_hash(height, &cellar_id, encoded_call); | ||
|
|
||
| let id = id_hash(height, &cellar_id, &encoded_call); |
There was a problem hiding this comment.
Based on our conversation we've modified the ID hashes of corks in somm to look like id_hash(height, chain_id, cellar_id, encoded_call), so we'll need to update our calculation here as well.
|
|
||
| let mut result: HashMap<u64, HashSet<String>> = HashMap::new(); | ||
| for id in cork_result.into_inner().cellar_ids { | ||
| let normalized_id = match to_checksum_address(&id) { |
There was a problem hiding this comment.
I suppose we can do this for safety's sake, but what we're really concerned with is the data in the incoming request -- the query server on the chain is going to give us strings in the form of checksum addresses.
| self.inner_cork.query_scheduled_corks_by_id(request).await | ||
| } | ||
|
|
||
| pub async fn get_axelar_scheduled_corks_by_id( |
There was a problem hiding this comment.
I saw this and was wondering what called it -- it turns out that I think this PR doesn't include the proposal thread looking at Axelar gov props.
There was a problem hiding this comment.
ah. I can do it in another PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.