Replace express-ws with ws #206
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. I'll have a proper review as soon as I can! :) |
|
I had forgotten about updating the tests, it might take me some time to do that, so not ready for review yet. I'll update when I can. |
PepsRyuu
reviewed
Jul 10, 2021
| @@ -120,6 +116,10 @@ async function devServer(options) { | |||
| app.use(fallback(entryPoint, { root: options.contentBase })); | |||
| } | |||
|
|
|||
| if (options.after) { | |||
| options.after(app, server); | |||
There was a problem hiding this comment.
Is there any particular reason for this to be moved below the fallback? This would be a breaking change, and it would probably cause the hook to not trigger at all if using historyApiFallback.
|
Went ahead with the removal of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I need to proxy websocket connection to my backend. I was unable to use
express-http-proxyorhttp-proxyalong withexpress-ws. There was an error during the upgrade handshake. Handling the upgrade directly withwsfixes the issue. I also added theserverobject to thebeforeandaftersince I needed it to handle the WS upgrade.Thanks for reviewing!