Revert eval in DB fix, changing back to 5.38 CV outside referencing behaviour #22635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #22547 |
tonycoz
changed the title
This reverts commit 386907f. Reinstates the behaviour of CV outside references from 5.38, fixing Perl#22547 Breaks Perl#19370
and a version with eval EXPR which will remain broken
tonycoz
force-pushed
the
22547-revert-db-eval
branch
from
c513c2f
to
891dd58
Compare
toddr
reviewed
Nov 18, 2024
| @@ -1975,7 +1976,8 @@ S_cv_clone_pad(pTHX_ CV *proto, CV *cv, CV *outside, HV *cloned, | |||
| PL_compcv = cv; | |||
| if (newcv) SAVEFREESV(cv); /* in case of fatal warnings */ | |||
|
|
|||
| CvOUTSIDE(cv) = CvREFCNT_inc_simple(outside); | |||
| if (CvHASEVAL(cv)) | |||
There was a problem hiding this comment.
FYI this doesn't backport cleanly into v5.40.0
There was a problem hiding this comment.
looks like CvREFCNT_inc_simple isn't a thing in v5.40.0
There was a problem hiding this comment.
looks like CvREFCNT_inc_simple isn't a thing in v5.40.0
I added it quite recently. For a backport you can just use regular SvREFCNT_inc and cast its return value
CvOUTSIDE(cv) = (CV *)SvREFCNT_inc(outside);There was a problem hiding this comment.
yep it's what I'm doing in my patch. It would be really good to see this backport and there to be a 5.40.1 given we're reverting a behavior that only breaks in 5.40 right now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts 386907f changing CV outside linking to match 5.38.
This is generally suitable for backporting to 5.40, more complex changes (like making outside a weakref) probably aren't.
I might add the perldelta later.
This is draft, I plan to add some other TODO tests for the other issues that came up in discussion.