-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for list of permissions in lookup-entity #1465
Open
ankitsheoran1
wants to merge
15
commits into
Permify:master
Choose a base branch
from
ankitsheoran1:support-for-array-of-permissions-in-lookup-entity
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
db07226
feat: add support for list of permissions in lookup-entity
14f612c
refactor: update variable name
d5b5fcd
fix: lookup test cases
tolgaOzen e76ab81
resolve conflicts
d9593b3
Merge branch 'support-for-array-of-permissions-in-lookup-entity' of g…
d2a5b08
fix: linked schema test case 19
e1c59ea
merge: latest master
ucatbas e3d94fd
feat: bulk-lookup-entity
ucatbas 4694441
Merge branch 'master' into support-for-array-of-permissions-in-lookup…
ucatbas ccb597f
feat: create new endpoint for list of permissions in lookup entity
d4f9b4b
Merge branch 'master' into support-for-array-of-permissions-in-lookup…
2ee4d81
fix: fixed compilable error
59f4462
fix: fixed lookup test cases
a17f7ee
fix: fixed lookup api docs
1d48d67
fix: fixed resolve merge conflicts
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clarification needed: Changes to PermissionLookupEntityResponse structure
The
PermissionLookupEntityResponse
definition has been modified, changing theentity_ids
field from an array of strings to an object withEntityIds
as values. While this change allows for a more structured response, it raises some concerns:entity_ids
suggests a simple list, which is no longer accurate.Please provide clarification on the following points:
entity_ids
object represent?Consider either reverting this change to maintain backward compatibility or providing a clear migration path and updating the field name to reflect its new structure.