Change: Support side-by-side fallback FontCaches instead of hierarchi… #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+404
to
+405
| // for (auto const &pair : font_mapping) { | ||
| // if (pair.second->fc == nullptr || pair.second->fc->IsBuiltInFont()) return nullptr; | ||
| // } |
Check notice
Code scanning / CodeQL
Commented-out code Note
| @@ -767,7 +767,7 @@ | |||
| this->SetWidgetDisabledState(WID_GO_GUI_FONT_AA, _fcsettings.prefer_sprite); | |||
| this->SetDirty(); | |||
|
|
|||
| InitFontCache(false); | |||
| // InitFontCache(false); | |||
Check notice
Code scanning / CodeQL
Commented-out code Note
|
|
||
| bool missing = callback->FindMissingGlyphs(); | ||
| Debug(fontcache, 1, "Font \"{}\" misses{} glyphs", (char *)file, missing ? "" : " no"); | ||
| for (FontSize fs = FS_BEGIN; fs != FS_END; fs++) { |
Check notice
Code scanning / CodeQL
Declaration hides variable Note
PeterN
force-pushed
the
side-by-side-font-cache
branch
from
df143b1 to
676cfa9
Compare
| if (this->level & 1) c = SwapRtlPairedCharacters(c); | ||
| this->glyphs.emplace_back(this->font->fc->MapCharToGlyph(c)); | ||
| this->glyph_to_char.push_back(i); | ||
| if (Utf16IsLeadSurrogate(*(buff + i))) ++i; |
Check notice
Code scanning / CodeQL
For loop variable changed in body Note
…cal. The text layouter system can now support using different fonts for different glyphs, including mixing scalable and sprite glyphs.
PeterN
force-pushed
the
side-by-side-font-cache
branch
from
676cfa9 to
536734e
Compare
This detaches sprite font glyph mappings from sprite fonts.
PeterN
force-pushed
the
side-by-side-font-cache
branch
from
536734e to
5c1f9ee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…cal.
The text layouter system can now support using different fonts for different glyphs, including mixing scalable and sprite glyphs.
Motivation / Problem
Description
Limitations
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.