Skip to content

Commit

Permalink
pruntime: Configurable ra max retries
Browse files Browse the repository at this point in the history
  • Loading branch information
kvinwang committed Jun 25, 2023
1 parent 41ef370 commit c7d7a9b
Show file tree
Hide file tree
Showing 3 changed files with 24 additions and 3 deletions.
3 changes: 3 additions & 0 deletions crates/phactory/api/src/ecall_args.rs
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,9 @@ pub struct InitArgs {

/// The timeout of getting the attestation report.
pub ra_timeout: Duration,

/// The max retry times of getting the attestation report.
pub ra_max_retries: u32,
}

pub use phala_git_revision::git_revision;
19 changes: 16 additions & 3 deletions crates/phactory/src/prpc_service.rs
Original file line number Diff line number Diff line change
Expand Up @@ -564,6 +564,7 @@ impl<Platform: pal::Platform + Serialize + DeserializeOwned> Phactory<Platform>
self.attestation_provider,
&runtime_info_hash,
self.args.ra_timeout,
self.args.ra_max_retries,
)?;
cached_resp.attestation = Some(report);
}
Expand Down Expand Up @@ -1235,16 +1236,26 @@ fn create_attestation_report_on<Platform: pal::Platform>(
attestation_provider: Option<AttestationProvider>,
data: &[u8],
timeout: Duration,
max_retries: u32,
) -> RpcResult<pb::Attestation> {
let encoded_report =
match platform.create_attestation_report(attestation_provider, data, timeout) {
let mut tried = 0;
let encoded_report = loop {
break match platform.create_attestation_report(attestation_provider, data, timeout) {
Ok(r) => r,
Err(e) => {
let message = format!("Failed to create attestation report: {e:?}");
error!("{}", message);
return Err(from_display(message));
if tried >= max_retries {
return Err(from_display(message));
}
let sleep_secs = (1 << tried).min(8);
info!("Retrying after {} seconds...", sleep_secs);
std::thread::sleep(Duration::from_secs(sleep_secs));
tried += 1;
continue;
}
};
};
Ok(pb::Attestation {
version: 1,
provider: serde_json::to_string(&attestation_provider).unwrap(),
Expand Down Expand Up @@ -1625,6 +1636,7 @@ impl<Platform: pal::Platform + Serialize + DeserializeOwned> PhactoryApi for Rpc
attestation_provider,
&worker_key_hash,
phactory.args.ra_timeout,
phactory.args.ra_max_retries,
)?)
} else {
info!("Omit RA report in workerkey response in dev mode");
Expand Down Expand Up @@ -1682,6 +1694,7 @@ impl<Platform: pal::Platform + Serialize + DeserializeOwned> PhactoryApi for Rpc
Some(AttestationProvider::Ias),
&handler_hash,
phactory.args.ra_timeout,
phactory.args.ra_max_retries,
)?)
} else {
info!("Omit client RA report for dev mode challenge");
Expand Down
5 changes: 5 additions & 0 deletions standalone/pruntime/src/main.rs
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,10 @@ struct Args {
/// The timeout of getting the attestation report. (in seconds)
#[arg(long, value_parser = parse_duration, default_value = "8s")]
ra_timeout: Duration,

/// The max retry times of getting the attestation report.
#[arg(long, value_parser = parse_duration, default_value = "1")]
ra_max_retries: u32,
}

#[rocket::main]
Expand Down Expand Up @@ -153,6 +157,7 @@ async fn serve(sgx: bool) -> Result<(), rocket::Error> {
safe_mode_level: args.safe_mode_level,
no_rcu: args.no_rcu,
ra_timeout: args.ra_timeout,
ra_max_retries: args.ra_max_retries,
}
};
info!("init_args: {:#?}", init_args);
Expand Down

0 comments on commit c7d7a9b

Please sign in to comment.