-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doesn't work with plugin Hirak/prestissimo #20
base: master
Are you sure you want to change the base?
Conversation
When using this plugin in conjunction with hirak/prestissimo, the download of acf-pro fails because the custom RemoteFileSystem is overwritten. In order to get it working, we should ensure that this plugins runs *after* hirak/prestissimo. As both are running with a priority set to 0, setting this one to -1 resolves the issue.
Can we please get this integrated? |
Thank you @mickaelperrin for your research and for submitting a pull request to solve the issue! Thank you again |
Can't wait until this being merged T_T |
I suggest someone forks this project and updates it |
Could you merge this @PhilippBaschke ? |
Just had to remove prestissimo for this one. |
@PhilippBaschke: +1 |
@PhilippBaschke: Are there plans for merging this in the near future? Just had this issue again. |
Same. Get it every two weeks everytime I start a new project... 😭 |
@randmanrjr: Have you (still) write access to this repository? Could you merge this in |
@strarsis I don't have write access to this repository. In the past, I made a small contribution via a pull request. |
Strange, I just tried it with hirak/prestissimo installed and it worked. 😕 |
When using this plugin in conjunction with hirak/prestissimo, the download of acf-pro fails because the custom RemoteFileSystem is overwritten. In order to get it working, we should ensure that this plugins runs after hirak/prestissimo.
As both are running with a priority set to 0, setting this one to -1 resolves the issue.