Show time remaining for other players' turns in multiplayer and some other features #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These classes are unique to the context and adding the verbosity of "Game" does not clarify anything so the prefix can be removed.
keyPressed fires before the text field is updated whereas keyReleased fires after it. The previous approach meant that using a single-character username was not possible because the validation saw an empty field. Now it is possible.
All the code to run the timer was in place, it just needed an extra if-statement to avoid trying to shoot when the timer ran out on another player's turn.
|
@StenAL Could you please check the failing unit test? |
This makes automating set-up for testing a bit easier as it skips the need to input a username. To test for username vailidity, I reused the logic from TrackTestLoginPanel and moved the validation logic into a separate class. This also removes the System.exit calls from Launcher.call; those code paths were impossible to test since the whole Java instance was getting terminated. By returning an integer instead, we can check the return codes in tests.
|
I fixed the test now, I had accidentally written |
pehala
reviewed
May 23, 2024
When this was fully commented, Maven was recompiling the entire source every time it was run because the file was invalid. See https://stackoverflow.com/questions/17944108/maven-compiler-plugin-always-detecting-a-set-of-sources-as-stale Since the class is unused, it can be deleted. This speeds up the iteration cycle of server development by a few seconds.
The fixes championship games in single player.
This is in preparation of making the "Try Again Now" button on the canvas work.
pehala
approved these changes
May 24, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following fixes/features:
System.exitanymoreDatabaseclass was fully commented out.This also includes some deobfuscation work in preparation of making the
Try Again Nowbutton work when a client is disconnected from the server.