Deobfuscate a lot more lobby code, remove TrackDumper #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This code creates the text area that users use to chat in lobbies. No functional changes.
No functional changes.
This is used for drawing the list of player names (grouped by languages if the locale is set). No functional changes.
This includes renaming UserListItem to just User as it is used as a general data class in multiple places. UserList is used to display and interact with the list of users in a lobby. No functional changes.
Looks like this was originally used to fetch tracks and records from the Playforia servers. It is no longer used in the codebase though and can be removed. TrackDumper contains a copy of the client connection code package com.aapeli.connection which can all be removed as a better-debofuscated copy is available in the client codebase.
PhilippvK
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains no functional changes, just lots of deobfuscation.
Also, TrackDumper is removed. Looks like it was originally used to fetch tracks and records from the Playforia servers. It is no longer used in the codebase though and can be removed.
TrackDumper contains a copy of the client connection code package
com.aapeli.connectionwhich can all be removed as a better-debofuscated copy is available in the client codebase.