Fix multiplayer quick start, adjust cut off text, and other minor fixes #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, this used the e.isMetaDown() check which was failing as modern Windows keyboards do not have a meta key. Changing this to check the mouse button fixes right clicking players in a lobby's player list which now opens a context menu.
When the client encounters a fatal error, it sends a `error-debug` packet including the last received and sent packages. This can contain whole maps and easily exceed the current maximum of 250 bytes.
These are sent by clients when they encounter fatal errors and contain useful information for debugging. Clients also sent an `end` packet afterwards and that was also unhandled. This is now handled as a no-op.
This logs all outgoing packets.
|
Hey @PhilippvK, pinging you in case you haven't seen this PR. I have some other changes ready to publish but would like to get this PR in first. |
|
@StenAL When the PR was posted I was traveling and could not try out the changes myself. Sorry for the delay! In the meantime I was able to check the changes and think we can get this merged soon. |
PhilippvK
reviewed
Nov 3, 2024
server/src/main/java/org/moparforia/server/net/packethandlers/golf/ChatHandler.java
Outdated
Show resolved
Hide resolved
PhilippvK
approved these changes
Nov 3, 2024
These are used by admins/sheriffs to do things like mute or ban people.
This currently just joins the multiplayer lobby which is an improvement over the previous behavior of deadlocking the client and forcing a restart.
These are handled server-side and assigned initialized as an anonymous user with names like "anon-xxxx".
Having two classes named `Conn` and `Connection` was a bit confusing. Now it's more clear that one is the app-agnostic socket-based connection while the other handles all networking for the golf game. Also, rename thriftLogs to metadataLogs as that's what they're used for.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This set of commits fixes many minor things:
old_quickjoin.webm
new_quickjoin.webm
Right clicking players in lobbies now opens a pop-up menu with some actions.
The server now handles
error-debug,end, andlobby commandpacketserror-debugis sent by the client when it crashes and includes an error message and the last commands sent/received. This is useful for debugging. It also necessitated increasing the maximum client package size to 2000 bytes since errors can be long.endandlobby commandare no-opsVerbose server logging can be enabled with a flag to see outgoing packets. This is useful for debugging.
The username regex no longer prevents empty strings as usernames. These are handled by the server and users are assigned a name like "~anonym1111"
Some networking classes are renamed for better clarity
Some unused classes and meaningless JavaDocs have been removed