Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eigen: Add NO_MODULE to find_package #125

Merged
merged 2 commits into from
Feb 24, 2024

Conversation

christophfroehlich
Copy link
Contributor

Closes #114

@ChrisThrasher
Copy link
Collaborator

Could you switch NO_MODULE to CONFIG? They do the same thing but I prefer the latter for stylistic reasons. Thanks!

Copy link

codecov bot commented Feb 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.65%. Comparing base (64d1f77) to head (22942c6).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #125   +/-   ##
=======================================
  Coverage   98.65%   98.65%           
=======================================
  Files          11       11           
  Lines         223      223           
=======================================
  Hits          220      220           
  Misses          3        3           
Flag Coverage Δ
humble 98.65% <ø> (ø)
rolling 98.65% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChrisThrasher ChrisThrasher merged commit 4e73bb0 into PickNikRobotics:main Feb 24, 2024
19 checks passed
@christophfroehlich christophfroehlich deleted the eigen branch February 24, 2024 21:54
christophfroehlich added a commit to ros-controls/ros2_rhel that referenced this pull request Feb 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compiling on RHEL8 fails
2 participants