-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding external dependencies as subtrees #46
Open
MikeWrock
wants to merge
10
commits into
subtree-pt1
Choose a base branch
from
subtree-pt2
base: subtree-pt1
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m commit 46a2619 git-subtree-dir: src/external_dependencies/picknik_accessories git-subtree-split: 46a2619b8fda90c9c06753edd7c22d0481eee6ae
…nal_dependencies/picknik_accessories'
… c0af316 git-subtree-dir: src/external_dependencies/ros2_kortex git-subtree-split: c0af31670108ea1b09ba31a1ed676ae3a7dbf525
…nal_dependencies/ros2_kortex'
…om commit 77e6092 git-subtree-dir: src/external_dependencies/ros2_robotiq_gripper git-subtree-split: 77e60927cd5cdcc7c75b8837ac3104b826a4bb99
…nal_dependencies/ros2_robotiq_gripper'
git-subtree-dir: src/external_dependencies/serial git-subtree-split: 69e0372cf0d3796e84ce9a09aff1d74496f68720
…nal_dependencies/serial'
b506424 removed unneeded files git-subtree-dir: src git-subtree-split: b50642414f565aba4012b35de676a9add6ee5065
dyackzan
reviewed
Nov 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that's because git subtrees do technically copy everything in, is that the intention here? Or should we actually be using a submodule?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately replacing a submodule with a subtree shows up as a all additions, so I've separated this in to a separate PR