-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pd: remove option from pd integration test #3180
Conversation
Signed-off-by: okJiang <[email protected]>
Based on the pull request title and diff, it seems that the Since there is no description provided for the pull request, it is difficult to determine the reasoning behind this change. However, if the job is critical and should always be run, then changing the As for potential problems, it is possible that this change could cause delays or issues if the job is resource-intensive and there are not enough available resources to run it for every pull request. It is also possible that if the job is not necessary for every pull request, then making it required could slow down the overall development process. If the job is indeed critical and should always be run, then I suggest leaving the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/hold wait for tikv/pd#8732
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: purelind The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
/unhold |
No description provided.