Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pd: remove option from pd integration test #3180

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

okJiang
Copy link
Contributor

@okJiang okJiang commented Oct 22, 2024

No description provided.

Copy link

ti-chi-bot bot commented Oct 22, 2024

I have already done a preliminary review for you, and I hope to help you do a better job.

Based on the pull request title and diff, it seems that the optional parameter in the latest-presubmits.yaml file is being changed from true to false for the pull-integration-realcluster-test job. This means that the job will now be required rather than optional.

Since there is no description provided for the pull request, it is difficult to determine the reasoning behind this change. However, if the job is critical and should always be run, then changing the optional parameter to false makes sense.

As for potential problems, it is possible that this change could cause delays or issues if the job is resource-intensive and there are not enough available resources to run it for every pull request. It is also possible that if the job is not necessary for every pull request, then making it required could slow down the overall development process.

If the job is indeed critical and should always be run, then I suggest leaving the optional parameter as false. However, if it is not necessary for every pull request, then it may be better to keep it as optional to prevent any delays or issues. Alternatively, it may be worth considering a different approach to ensure that the job is run when necessary without causing delays or issues for other pull requests.

@ti-chi-bot ti-chi-bot bot added the size/XS label Oct 22, 2024
Copy link
Collaborator

@purelind purelind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

/hold wait for tikv/pd#8732

Copy link

ti-chi-bot bot commented Oct 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: purelind

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

ti-chi-bot bot commented Oct 22, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-10-22 02:47:26.487203968 +0000 UTC m=+319247.183994570: ☑️ agreed by purelind.

@ti-chi-bot ti-chi-bot bot added the approved label Oct 22, 2024
@okJiang
Copy link
Contributor Author

okJiang commented Oct 22, 2024

/unhold

@ti-chi-bot ti-chi-bot bot merged commit c1beb7b into PingCAP-QE:main Oct 22, 2024
2 checks passed
@okJiang okJiang deleted the enable-pd-option branch October 22, 2024 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants