Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vacuum Topic auto detection and Generate Predefined Zones capability #685

Open
wants to merge 13 commits into
base: dev
Choose a base branch
from
Open

Vacuum Topic auto detection and Generate Predefined Zones capability #685

wants to merge 13 commits into from

Conversation

sca075
Copy link

@sca075 sca075 commented Nov 26, 2023

  • Added detection of this._camera attribute "vacuum_topic" when on the vacuum platform is specified to use the "topic" within "internal_variables"
  • Added for in the Valetudo's json's the "internal_variables" and corrected the parsing of the predefined zones and points from ROOMS to appropriate selection type (should solve issue Hypfer/Valetudo and vacuum_clean_zone_predefined are completelly broken #662).
  • Check of this function:
  • No attribute "vaccum_topic" = standard as before
  • Check with attribute in camera, no problem.
  • Check second card different vacuum and platform okay => the platform need to be re-select if the camera change.
  • Added also the zone config, as per RE vacuums provide predefined zones. Therefore zones will be configured (note room or zones not possible at this time to do both)
  • Updated some of the requirements in the package.
  • Test on Crome and Safari okay no errors logged by console.
  • Tested on PI4 (Home Assistant OS)
  • Other Vacuum Platforms Tested.
  • Other camera sources.

No braking changes expected, updated only EN translation at this time.

@sca075
updates Valetudo Vacuum Camera
a0733a6 
- Topic internal variable autogenerated.
- rand256 and hypfer templates updated for predefined zones and points
@sca075
types.ts added zone config
4788a7f 
added events and map extraction data.
@sca075
added zones to en.json
78c2500 
added label for predefined zones configuration
@sca075
Update package.json
3487e04 
beta version 2.2.3
@sca075
Update xiaomi-vacuum-map-card.ts
1fec2fe 
Reverted changes for topic, added getpredefifinedzones
@sca075
Update editor.ts
a79ea2d
@sca075
Update const.ts
e5ac429
@sca075
Update rand256_valetudo_re.json
d676e38
@sca075
Update hypfer_valetudo.json
0261df3
@sca075
Update platform-generator.ts
29b3181
@sca075
Delete src/hypfer_valetudo.json
5486312
@sca075
Delete src/rand256_valetudo_re.json
4c15a77
@sca075
Update package.json
bb4be41 
Error during compiling on github
@sca075
Copy link
Author

sca075 commented Nov 27, 2023

@PiotrMachowski I did modify the package.json as per there was a GitHub requirement to fix the version number. The submitted changes were also tested as described, thanks as always for the cooperation :)

@PiotrMachowski PiotrMachowski changed the base branch from master to dev November 27, 2023 15:51
@PiotrMachowski PiotrMachowski linked an issue Nov 29, 2024 that may be closed by this pull request
Valetudo not working for rooms/zones? #778
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Valetudo not working for rooms/zones?
1 participant
@sca075