Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump webgpu to 0.8 #1416

Closed
wants to merge 3 commits into from
Closed

Bump webgpu to 0.8 #1416

wants to merge 3 commits into from

Conversation

AlexEne
Copy link
Contributor

@AlexEne AlexEne commented May 13, 2021

I've upgraded webgpu. I can't run all the tests as I'm on windows and don't have ninja installed. Hopefully if there's anything wrong the CI will pick it up.

I did run the webgpu backend tests and those were fine.

@AlexEne
Copy link
Contributor Author

AlexEne commented May 15, 2021

I noticed the fmt failiure. Checking what vulkano version works.
It seems that vulkano 0.22 builds fine under WSL. It actually doesn't build :D. Will further dig into it.

@AlexEne
Copy link
Contributor Author

AlexEne commented May 15, 2021

So in order to fix the build due to the change here

Rename shaderf3264 to shaderFloat64

I need to upgrade to vulkano at at least 0.20 from the current 0.16.
This will take a while and I think I need some help as I'm not too familiar with vulkan.
I can cope with some WGPU-RS changes, this is a bit complicated and will take me some time to figure out as a bunch of things have happened in Vulkan in the meantime.

@mitchmindtree
Copy link
Contributor

Hey @AlexEne don't stress about the vulkano backend if you don't have the time! While it would be nice to have it out of date, it was broken before this PR and isn't related - happy to leave that for a future fix. See #1409 for some context.

Going to take a look at this now!

@mitchmindtree
Copy link
Contributor

When attempting to run the all_winit_wgpu example (NixOS, GNOME Wayland, Intel GPU), I'm running into the following validation error during shader module creation:

wgpu error: Validation Error

Caused by:
    In Device::create_shader_module
      note: label = `shaders/frag.spv`
    Function [1] 'main' is invalid
    Required uniformity of control flow for IMPLICIT_LEVEL in [20] is not fulfilled because of Expression([1])


thread 'main' panicked at 'Handling wgpu errors as fatal by default', /home/mindtree/.cargo/registry/src/github.com-1ecc6299db9ec823/wgpu-0.8.1/src/backend/direct.rs:1955:5

Looking at the diff, I think it is unlikely this is to do with anything you have changed, as the error is related to validation of the SPIR-V shader which hasn't changed in a while. Likely, this is one of the new validation checks picking up something wrong with old code. Will have a look

@mitchmindtree
Copy link
Contributor

It's a bit of a strange one - I've opened an issue here gfx-rs/wgpu-rs#912.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants